Move out protocol fee into separate file #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcis96
reviewed
Dec 14, 2023
narcis96
approved these changes
Dec 14, 2023
MartinquaXD
reviewed
Dec 15, 2023
fleupold
reviewed
Dec 15, 2023
crates/autopilot/src/run_loop.rs
Outdated
| @@ -497,6 +498,7 @@ pub fn solve_request( | |||
| time_limit: Duration, | |||
| fee_policy: arguments::FeePolicy, | |||
| ) -> solve::Request { | |||
| let fee_policies = protocol::fee::fee_policies(auction, fee_policy); | |||
There was a problem hiding this comment.
I would make this an object that is instantiated with the fee_policy config (and then passed as a dependency into the runloop instead of the fee_policy).
I assume this object will get more dependencies, such as app data look up, quote finding, etc.
There was a problem hiding this comment.
In the next iteration we can have the fee::PolicyFactory that will contain arguments::FeePolicy and Arc<Database> and be defined on the RunLoop level, while by given Auction it creates the fee::Policies object.
|
Merging to unblock the dependent PR #2188. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #2098
Implements second part of the comment: #2098 (comment)
Moves out the fee policy preparation of the auction into a separate file. This file should contain all the logic around protocol fees.