[EASY] Update most_recent_cip_20_data #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
added
the
E:6.2 Time to Happy Moo
squadgazzz
reviewed
Sep 17, 2024
| const QUERY: &str = r#" | ||
| SELECT * | ||
| FROM settlement_observations so | ||
| JOIN settlements s ON s.log_index = so.log_index AND s.block_number = so.block_number | ||
| WHERE s.tx_hash = $1 | ||
| WHERE s.tx_hash = ANY($1) |
There was a problem hiding this comment.
We should probably avoid using Postgres-specific syntax.
squadgazzz
reviewed
Sep 17, 2024
Comment on lines
32
to
+35
| pub async fn fetch( | ||
| ex: &mut PgConnection, | ||
| tx_hash: &TransactionHash, | ||
| ) -> Result<Option<Observation>, sqlx::Error> { | ||
| tx_hashes: &[TransactionHash], | ||
| ) -> Result<Vec<Observation>, sqlx::Error> { |
There was a problem hiding this comment.
Looks like the table is used only for debugging and never queried outside the e2e tests, right? How about specifying this right in the docs?
There was a problem hiding this comment.
Do you mean in the database readme or?
squadgazzz
approved these changes
Sep 17, 2024
MartinquaXD
approved these changes
Sep 19, 2024
m-lord-renkse
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2992
settlement_scores::fetchwill be updated once the #2980 is merged.How to test
Existing univ2 e2e test.