Use traces to extract the input for settlement::Observer
#3233
Conversation
| @@ -29,8 +29,6 @@ pub struct Settlement { | |||
| gas: eth::Gas, | |||
| /// The effective gas price of the settlement transaction. | |||
| gas_price: eth::EffectiveGasPrice, | |||
| /// The address of the solver that submitted the settlement transaction. | |||
| solver: eth::Address, | |||
There was a problem hiding this comment.
Not strictly related to the task but removed for completeness, so we don't have to rethink how this field should be populated.
There was a problem hiding this comment.
Logic looks good to me.
The bit where the auction id gets spliced off the settle() call might have to change in the future depending on the helper contracts. If the auction id gets appended to the overall function call the solidity logic of the helper contracts doesn't have to handle it at all which would probably result in gas savings. Not sure if those are big enough to matter in practice, though.
|
Refactored the error handling to notify more loudly if execution client bug is detected. Also, added the unit test to verify that |
Description
Implements first part of #3177
The expectation for "auction_id" remain the same:
auction_idis expected at the end of the/settlecall/sub_call.Changes
trace_transactionfunction to get traces and extract the calldata ofsettlecallHow to test
Existing tests show that no regression bugs were introduced.
Final e2e test should cover this part of the code. Although by manually testing the
trace_transactionI am pretty sure the code is correct.