Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ComposableCoW bytecode check #151

Merged
merged 7 commits into from
May 10, 2024
Merged

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented May 10, 2024

Description

Removes the janky bytecode check that was being used to enforce that the contract being indexed was ComposableCoW compatible. This is possible given that there are exhaustive switch statements that were published for the revert messages.

Changes

  • Add a try/catch around the decode function result to catch bad ComposableCoW-like implementations.
  • Remove bytecode checks.

How to test

  1. Remove the sepolia database.
  2. Restart
  3. Observe new CoW AMMs 🚀

@mfw78 mfw78 added the bug Something isn't working label May 10, 2024
@mfw78 mfw78 requested a review from fedgiac May 10, 2024 09:42
@mfw78 mfw78 self-assigned this May 10, 2024
Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mfw78 mfw78 force-pushed the drop-composablecow-bytecode-check branch from 5369ad9 to 6b84bce Compare May 10, 2024 11:04
@mfw78 mfw78 force-pushed the drop-composablecow-bytecode-check branch from 6b84bce to 9da1c07 Compare May 10, 2024 12:05
@mfw78 mfw78 merged commit cd466da into main May 10, 2024
4 checks passed
@mfw78 mfw78 deleted the drop-composablecow-bytecode-check branch May 10, 2024 14:04
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants