-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add inserted_additional_messages to chat response #169
Conversation
增加conversation.chat.created事件中的inserted_additional_messages字段
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces a new class Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cozepy/chat/__init__.py (1)
324-324
: Add docstring for the new field.The new field
inserted_additional_messages
would benefit from documentation explaining its purpose and usage. Consider adding a docstring comment similar to other fields in the class.usage: Optional[ChatUsage] = None - inserted_additional_messages: Optional[List[ChatInsertedAdditionalMessage]] = None + # List of additional messages that were inserted into the chat. + # These messages are typically system-generated or automatically inserted content. + inserted_additional_messages: Optional[List[ChatInsertedAdditionalMessage]] = None
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cozepy/chat/__init__.py
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test (Python 3.8 on Windows)
🔇 Additional comments (1)
cozepy/chat/__init__.py (1)
286-288
: LGTM! Clean and well-structured model class.The
ChatInsertedAdditionalMessage
class follows the established patterns in the codebase, inheriting fromCozeModel
and maintaining a simple, focused structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 标题改成 feat: 开头,然后换成英文
- commit 也是
- ci 没有过: 运行一下
poetry run ruff format
,然后合并一下 commit 再 push 一下
…ionalMessage` class
inserted_additional_messages
field and ChatInsertedAdditionalMessage
class
inserted_additional_messages
field and ChatInsertedAdditionalMessage
classinserted_additional_messages
field and ChatInsertedAdditionalMessage
class
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 89.88% 89.84% -0.05%
==========================================
Files 63 63
Lines 5765 5768 +3
==========================================
Hits 5182 5182
- Misses 583 586 +3
|
inserted_additional_messages
field and ChatInsertedAdditionalMessage
class
增加conversation.chat.created事件中的inserted_additional_messages字段 #168
Summary by CodeRabbit