Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor CozePKCEAuthError to use CozePKCEAuthErrorType Enum #58

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

chyroc
Copy link
Collaborator

@chyroc chyroc commented Oct 8, 2024

  • Replaced Literal["authorizationpending", "slowdown", "accessdenied", "expiredtoken"] with CozePKCEAuthErrorType Enum
  • Optimized type annotations for CozePKCEAuthError

@chyroc chyroc added the chore Project maintenance work not related to features and bug fixes label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 98.74%. Comparing base (835e22c) to head (35c3a0a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cozepy/auth/__init__.py 20.00% 4 Missing ⚠️
@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   98.73%   98.74%           
=======================================
  Files          38       38           
  Lines        2298     2304    +6     
=======================================
+ Hits         2269     2275    +6     
  Misses         29       29           
Files with missing lines Coverage Δ
cozepy/__init__.py 100.00% <100.00%> (ø)
cozepy/exception.py 100.00% <100.00%> (ø)
cozepy/request.py 97.93% <100.00%> (ø)
tests/test_auth.py 100.00% <ø> (ø)
tests/test_exception.py 100.00% <100.00%> (ø)
cozepy/auth/__init__.py 92.95% <20.00%> (ø)

@chyroc chyroc force-pushed the chore-coze-pkce-auth-error-type branch 4 times, most recently from 79ad30e to e035574 Compare October 8, 2024 14:59
@chyroc chyroc force-pushed the chore-coze-pkce-auth-error-type branch from e035574 to 35c3a0a Compare October 8, 2024 15:01
@chyroc chyroc merged commit db19fc5 into main Oct 8, 2024
12 of 13 checks passed
@chyroc chyroc deleted the chore-coze-pkce-auth-error-type branch October 8, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project maintenance work not related to features and bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant