-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ask for personal info before a transfer #1847
Conversation
test nationality selectbox valuecozy-banks/src/ducks/personal-info/index.spec.jsx Lines 40 to 45 in 87b0cf3
This comment was generated by todo based on a
|
87b0cf3
to
5c46d0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and questions, but nothing major!
If the flag('banks.transfers.need-personal-information') is set to true, the myself contact will be fetched when the transfer page is mounted. We check if the birth city and nationality have been filled and if they are not filled, we display a form that edits the myself contact
Needed to modify the myself contact
We do not need the bar's API during tests
5c46d0b
to
4da2403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM!
In some cases, we will want to ask the user some information
before allowing transfers.
and nationality are present
It can be in a "Page" in the transfer page tab : when present, the
transfer stepper is hidden, and the form takes its place. It can also
be in a modal because it can be also accessed from the settings.
🚩 The "banks.transfers.need-personal-information" flag controls