[DAT-75] Correctly handle refreshToken for dataproxy replication #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
approved these changes
Feb 7, 2025
|
In order to ease history tracking, the failing test on the expired token message is a side effect of this previous commit where we introduced errors aggregation 5373877 |
paultranvan
force-pushed
the
refreshtokenworker
branch
from
4beba20 to
7235a26
Compare
The refreshToken detection was failing in replication, because an AggregateError is made. We now handle such situation.
paultranvan
force-pushed
the
refreshtokenworker
branch
5 times, most recently
from
c1f1fe5 to
753cad4
Compare
Ldoppea
approved these changes
Feb 11, 2025
Comment on lines
212
to
214
| if (token) { | ||
| token = token || data.cozyToken | ||
| token = token || cozyData.cozyToken | ||
| } |
There was a problem hiding this comment.
This block can be removed, data.cozyToken is from the appNode.dataset you removed.
There was a problem hiding this comment.
Here is the result when calling document.querySelector('div[role="application"]').dataset:
The dataset.cozy value comes from the data-cozy attribute
All the dataset.cozyXxx values come from the deprecated data-cozy-xxx attributes
There was a problem hiding this comment.
Nice, thanks for the info, I was unsure of that
paultranvan
force-pushed
the
refreshtokenworker
branch
from
0f2d55c to
1f19659
Compare
BREAKING CHANGE: The `data-cozy-token` injection is no longer supported for refreshToken. We used to rely on DOMParser to extract the new token during a refreshToken procedure. However, DOMParser is a web API, which is not available in web workers, nor in node env. Therefore, we implement our own HTML parsing, relying on the `data-cozy` attribute in HTML. We tried using external libraries such as JSDom, fauxdom or linkedom, but got build issues with all those libs. It was somehow manageable, but required some additional config in consuming apps. As the HTML parsing is quite basic, we decided that it is not worth the effort, and we now do the parsing ourselves, making it available in web, workers, and node envs. As a consequence, we do not support the `data-cozy-token` existence anymore, as it would require extra work and is seen as deprecated for several years now. If your app still somehow require it, you need to migrate the app template to rely on `data-cozy` like this: https://github.com/cozy/cozy-drive/blob/master/src/targets/browser/index.ejs#L37
paultranvan
force-pushed
the
refreshtokenworker
branch
from
1f19659 to
bf77232
Compare
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
paultranvan
pushed a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
paultranvan
pushed a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 11, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
Ldoppea
added a commit
to cozy/cozy-flagship-app
that referenced
this pull request
Feb 12, 2025
`cozy-client` and `cozy-pouch-link` have been upgraded to `54.0.0` in order to retrieve a fix on the refreshToken mechanism that did not work when token expired during a Pouch replication Related PR: cozy/cozy-client#1587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes: