-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show number of new sharing in the sidebar #2964
Conversation
BundleMonFiles updated (3)
Unchanged files (16)
Total files change +1.77KB +0.04% Groups updated (3)
Unchanged groups (5)
Final result: ✅ View report in BundleMon website ➡️ |
0cd7650
to
e2f110c
Compare
e2f110c
to
ceb9c22
Compare
ceb9c22
to
2e83623
Compare
src/drive/web/modules/queries.js
Outdated
class: 'shortcut', | ||
'metadata.sharing.status': 'new' | ||
}) | ||
.indexFields(['class', 'metadata.sharing.status']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should invert the both fields. class
is less restrictive than metatada.sharing.status
and to have better performance we should always put first in the index the more restrictive field.
src/drive/web/modules/queries.js
Outdated
}) | ||
.indexFields(['class', 'metadata.sharing.status']), | ||
options: { | ||
as: 'io.cozy.files/new_sharing_shortcut', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as
should be "technically named" not "functionally named". Because the name is used to reuse a request, it's easier to reuse the same request if the name is technical instead of functional.
See https://github.com/cozy/cozy-guidelines/#naming-of-queries
Here something like: io.cozy.files/metadata.sharing.status/new/class/shortcut
2e83623
to
78d80e1
Compare
On desktop :
On tablet & mobile :