Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show number of new sharing in the sidebar #2964

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

cballevre
Copy link
Member

@cballevre cballevre commented Aug 8, 2023

### ✨ Features

* Show number of new sharing in the sidebar

On desktop :
Capture d’écran 2023-08-10 à 10 55 15

On tablet & mobile :
Capture d’écran 2023-08-10 à 11 45 18

@bundlemon
Copy link

bundlemon bot commented Aug 8, 2023

BundleMon

Files updated (3)
Status Path Size Limits
drive/app/drive.(hash).js
243.61KB (+830B +0.33%) 255KB
drive/public/drive.(hash).js
1.5MB (+499B +0.03%) 1.65MB
drive/intents/drive.(hash).js
148.95KB (+486B +0.32%) 171KB
Unchanged files (16)
Status Path Size Limits
drive/vendors/drive.(hash).js
1.28MB 1.6MB
drive/public/pdf.worker.entry.(hash).worker.j
s
343.37KB 345KB
drive/services/dacc/drive.js
253.91KB 500KB
drive/services/qualificationMigration/drive.j
s
248.95KB 500KB
drive/public/cozy-client-js.js
158.97KB 160KB
drive/public/drive.(hash).min.css
93.36KB 100KB
drive/app-drive.(hash).min.css
55.99KB 56KB
drive/intents-drive.(hash).min.css
37.07KB 40KB
drive/onlyOffice/slide.pptx
24.82KB 25KB
drive/onlyOffice/text.docx
5.84KB 6KB
drive/onlyOffice/spreadsheet.xlsx
5.01KB 6KB
drive/manifest.webapp
1.77KB 2KB
drive/index.html
531B 1KB
drive/intents/index.html
517B 1KB
drive/img/app-icon.(hash).svg
419B 1KB
drive/manifest.json
184B 1KB

Total files change +1.77KB +0.04%

Groups updated (3)
Status Path Size Limits
drive/app/**
243.61KB (+830B +0.33%) +1%
drive/public/**
2.09MB (+499B +0.02%) +7%
drive/intents/**
149.45KB (+485B +0.32%) +6%
Unchanged groups (5)
Status Path Size Limits
drive/screenshots/**
2.13MB +0.4%
drive/vendors/**
1.28MB +6%
drive/services/**
502.86KB +1%
drive/onlyOffice/**
35.68KB +0.4%
drive/img/**
419B +0.4%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@cballevre cballevre force-pushed the feat/show-new-sharing-in-sidebar branch 2 times, most recently from 0cd7650 to e2f110c Compare August 10, 2023 14:57
@cballevre cballevre marked this pull request as ready for review August 10, 2023 14:59
@cballevre cballevre requested a review from zatteo as a code owner August 10, 2023 14:59
@cballevre cballevre requested a review from Crash-- August 10, 2023 14:59
@cballevre cballevre force-pushed the feat/show-new-sharing-in-sidebar branch from e2f110c to ceb9c22 Compare August 24, 2023 12:42
@cballevre cballevre force-pushed the feat/show-new-sharing-in-sidebar branch from ceb9c22 to 2e83623 Compare August 24, 2023 12:45
class: 'shortcut',
'metadata.sharing.status': 'new'
})
.indexFields(['class', 'metadata.sharing.status']),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should invert the both fields. class is less restrictive than metatada.sharing.status and to have better performance we should always put first in the index the more restrictive field.

})
.indexFields(['class', 'metadata.sharing.status']),
options: {
as: 'io.cozy.files/new_sharing_shortcut',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as should be "technically named" not "functionally named". Because the name is used to reuse a request, it's easier to reuse the same request if the name is technical instead of functional.

See https://github.com/cozy/cozy-guidelines/#naming-of-queries

Here something like: io.cozy.files/metadata.sharing.status/new/class/shortcut

@cballevre cballevre force-pushed the feat/show-new-sharing-in-sidebar branch from 2e83623 to 78d80e1 Compare August 24, 2023 16:14
@cballevre cballevre merged commit 3d63638 into master Aug 25, 2023
3 checks passed
@cballevre cballevre deleted the feat/show-new-sharing-in-sidebar branch August 25, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants