Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VO-1187] fix: Opening note inside public repository #3244

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[VO-1187] fix: Opening note inside public repository #3244

merged 2 commits into from
Nov 15, 2024

Conversation

cballevre
Copy link
Member 

### 🐛 Bug Fixes

* Opening note inside public repository

@cballevre
fix(ExternalRedirect): Keep the same background color
638f16b 
Adding a <Layout> allows you to keep the same background color on redirect pages. This improves the user experience with the potential use of a dark theme. Before, it was the default color of the browser that was displayed without taking user preference in account
@cballevre
feat: Open note inside public repository
79a98a8 
The opening of the notes is subtle. The note is always opened in the instance of the note creator. This is especially true for shared notes or notes in shared folders. In this case, you need to contact the cozy-stack to find out where to open it. As this can take a little time, we use a redirection page rather than pre-calculating all the links when a folder is displayed
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 14, 2024

BundleMon

Files added (18)
Status Path Size Limits
✅ vendors/drive.(hash).js
 +1.79MB 2MB
✅ public/drive.(hash).js
 +1.56MB 1.7MB
✅ public/pdf.worker.entry.(hash).worker.js
 +345.35KB 350KB
✅ services/qualificationMigration/drive.js
 +282.15KB 500KB
✅ services/dacc/drive.js
 +263.08KB 500KB
✅ app/drive.(hash).js
 +161.89KB 300KB
✅ public/cozy-client-js.js
 +159.28KB 160KB
✅ intents/drive.(hash).js
 +87.91KB 190KB
✅ public/drive.(hash).min.css
 +39.94KB 100KB
✅ onlyOffice/slide.pptx
 +24.83KB 25KB
✅ app-drive.(hash).min.css
 +10.73KB 56KB
✅ intents-drive.(hash).min.css
 +7.89KB 40KB
✅ onlyOffice/text.docx
 +5.85KB 6KB
✅ onlyOffice/spreadsheet.xlsx
 +5.02KB 6KB
✅ manifest.webapp
 +1.87KB 2KB
✅ index.html
 +598B 1KB
✅ intents/index.html
 +509B 1KB
✅ manifest.json
 +185B 1KB

Total files change +4.72MB

Groups added (7)
Status Path Size Limits
✅ public/**
 +2.11MB -
✅ vendors/**
 +1.79MB -
✅ services/**
 +545.23KB -
✅ app/**
 +161.89KB -
✅ intents/**
 +88.4KB -
✅ onlyOffice/**
 +35.7KB -
✅ img/**
 +5.85KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

zatteo
zatteo approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@zatteo zatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good well done !

@cballevre cballevre merged commit 07917d0 into release/1.74.2 Nov 15, 2024
2 checks passed
@cballevre cballevre deleted the fix/notes-public-link branch November 15, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@Merkur39 Merkur39 Awaiting requested review from Merkur39

@acezard acezard Awaiting requested review from acezard acezard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cballevre @zatteo