Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show share synchronization as a minor action (Part 1) #3250

Merged
merged 12 commits into from
Nov 22, 2024
Merged

feat: Show share synchronization as a minor action (Part 1) #3250

merged 12 commits into from
Nov 22, 2024

Conversation

Merkur39
Copy link
Member

@Merkur39 Merkur39 commented Nov 21, 2024 •
edited
Loading

Multiple updates, to facilitate future functionalities!

  • Replacement of the latest ActionMenu
  • Updated cozy-ui & cozy-harvest-lib, and added cozy-viewer
  • Various adjustments

@Merkur39 Merkur39 force-pushed the feat/vo-1202 branch 3 times, most recently from 4b72b27 to 2d98bed Compare November 21, 2024 17:35
@Merkur39
feat: Upgrade cozy-ui to 113.3.0 & cozy-harvest-lib to 30.6.4
a6b7fc7 
Manage breaking changes with cozy-viewer
@Merkur39
refactor: Rename SelectableItem's prop
df2024a
@Merkur39
fix(DeleteItem): Missing props
f7631f0 
The `onLeave` & `isSharedWithMe` props have not
been transmitted for a long time.
`onLeave` is no longer useful, it used to call a stack
route to revoke the user, but the approach has since
changed and deleting an io.cozy.files revokes the user.

`isSharedWithMe` is still useful, allowing you to
customize the wording.
@Merkur39
feat: Customize trash action
402a6c9 
To remain consistent with the wording in MoreMenu.
@Merkur39
fix(PublicFolderView): Add Divider and organise actions in ActionsMenu
2ba37df
@Merkur39
feat: Display MoreMenu all the time
1997c25 
This change is necessary with the upcoming functionality.
As there will no longer be a banner to add/sync the share.
@Merkur39
feat(ActionMenuWithHeader): Remove useless argument in ActionsMenu
fdaa92b
@Merkur39
feat: Add openExternalLink action
94503ef
@Merkur39
feat: Update french text of the leave shared folder button
409d05a
@Merkur39
feat: Replace the last depreciated ActionMenu's
3c2d5c1
@Merkur39 Merkur39 marked this pull request as ready for review November 21, 2024 18:15
@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 21, 2024 •
edited
Loading

BundleMon

Files updated (6)
Status Path Size Limits
✅ public/drive.(hash).js
 1.59MB (+18.66KB +1.16%) 1.7MB
✅ vendors/drive.(hash).js
 1.83MB (+17.12KB +0.92%) 2MB
✅ app/drive.(hash).js
 162.29KB (+391B +0.24%) 300KB
✅ intents/drive.(hash).js
 87.94KB (+35B +0.04%) 190KB
✅ app-drive.(hash).min.css
 10.69KB (-36B -0.33%) 56KB
✅ public/drive.(hash).min.css
 39.47KB (-487B -1.19%) 100KB
Unchanged files (12)
Status Path Size Limits
✅ public/pdf.worker.entry.(hash).worker.js
 345.35KB 350KB
✅ services/qualificationMigration/drive.js
 282.43KB 500KB
✅ services/dacc/drive.js
 263.32KB 500KB
✅ public/cozy-client-js.js
 159.28KB 160KB
✅ onlyOffice/slide.pptx
 24.83KB 25KB
✅ intents-drive.(hash).min.css
 7.89KB 40KB
✅ onlyOffice/text.docx
 5.85KB 6KB
✅ onlyOffice/spreadsheet.xlsx
 5.02KB 6KB
✅ manifest.webapp
 1.87KB 2KB
✅ index.html
 598B 1KB
✅ intents/index.html
 509B 1KB
✅ manifest.json
 185B 1KB

Total files change +35.68KB +0.73%

Groups updated (4)
Status Path Size Limits
✅ public/**
 2.14MB (+18.18KB +0.84%) -
✅ vendors/**
 1.83MB (+17.12KB +0.92%) -
✅ app/**
 162.29KB (+391B +0.24%) -
✅ intents/**
 88.44KB (+36B +0.04%) -
Unchanged groups (3)
Status Path Size Limits
✅ services/**
 545.74KB -
✅ onlyOffice/**
 35.7KB -
✅ img/**
 5.85KB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@Merkur39 Merkur39 changed the title feat: Show share synchronization as a minor action feat: Show share synchronization as a minor action (Part 1) Nov 21, 2024
cballevre
cballevre reviewed Nov 22, 2024
View reviewed changes
src/modules/viewer/FileOpenerExternal.jsx Outdated Show resolved Hide resolved
src/modules/viewer/FilesViewer.jsx Outdated Show resolved Hide resolved
src/modules/views/OnlyOffice/Error.jsx Outdated Show resolved Hide resolved
src/modules/drive/Toolbar/selectable/SelectableItem.jsx Outdated Show resolved Hide resolved
src/modules/drive/Toolbar/delete/DeleteItem.jsx Show resolved Hide resolved
src/modules/actions/index.jsx Show resolved Hide resolved
src/modules/views/Drive/DriveFolderView.jsx Show resolved Hide resolved
src/modules/drive/Toolbar/components/AddEncryptedFolderItem.jsx Outdated Show resolved Hide resolved
src/modules/drive/AddMenu/AddMenu.jsx Show resolved Hide resolved
cballevre
cballevre approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Merkur39 Merkur39 merged commit e442c4b into master Nov 22, 2024
4 checks passed
@Merkur39 Merkur39 deleted the feat/vo-1202 branch November 22, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cballevre cballevre cballevre approved these changes

@acezard acezard Awaiting requested review from acezard acezard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Merkur39 @cballevre