Skip to content

Commit

Permalink
feat: Log any error intercepted by the konnector
Browse files Browse the repository at this point in the history
Before we expected the job to contain and display this error but if the
error occurs before the job is created (in authentication phase), the
error won't be added to the logs and it makes it difficult to debug.
  • Loading branch information
doubleface committed Aug 10, 2023
1 parent 9fc67ee commit 1729e64
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/libs/ReactNativeLauncher.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ class ReactNativeLauncher extends Launcher {
deactivateKeepAwake('clisk')
const { client, job } = this.getStartContext()

if (message) {
this.log({ level: 'error', message, timestamp: new Date().toISOString() })
}
await sendKonnectorsLogs(client)
if (job) {
launcherEvent.emit('launchResult', { cancel: true })
Expand Down

0 comments on commit 1729e64

Please sign in to comment.