Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: install share app extension on Android #893

Closed
wants to merge 3 commits into from
Closed

feat: install share app extension on Android #893

wants to merge 3 commits into from

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Aug 2, 2023

No description provided.

@acezard
feat: install share app extension on Android
e3fc87d 
Had to patch the extension to change
android build gradle settings
Ldoppea
Ldoppea reviewed Aug 3, 2023
View reviewed changes
android/app/src/main/java/share/ShareActivity.java Outdated Show resolved Hide resolved
android/app/src/main/java/share/ShareActivity.java Outdated
@Override
protected String getMainComponentName() {
// this is the name AppRegistry will use to launch the Share View
return "MyShareEx";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we customize this name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ldoppea yeah, I kept the same because it was simpler to follow documentation, but not sure what name we should use. Do you have any suggestion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated

@Ldoppea
Copy link
Member

Ldoppea commented Aug 3, 2023 •
edited
Loading

The patch seems to be very large, is that expected?

@acezard
Copy link
Contributor Author

acezard commented Aug 4, 2023 •
edited
Loading

The patch seems to be very large, is that expected?

yes it's because of the patch-package. Maybe it's better to fork then (same issue for iOS btw)?

@acezard acezard requested a review from Ldoppea August 4, 2023 08:30
@Ldoppea
Copy link
Member

Ldoppea commented Aug 4, 2023 •
edited
Loading

The patch seems to be very large, is that expected?

yes it's because of the patch-package. Maybe it's better to fork then (same issue for iOS btw)?

Usually when the patch file is so big there is a configuration problem behind.
In a normal context when you edit one file and run this tool, only a few lines should appear in the patch. Here there are tons of diff which give the impression that the diff has been run using the wrong version between the local one and the package.json one (i.e. this can happen if you are using a yarn link)

@Crash--
Copy link
Contributor

Crash-- commented Aug 29, 2023

@acezard Still needed? Should we close it?

@acezard
Copy link
Contributor Author

acezard commented Aug 29, 2023

@acezard Still needed? Should we close it?

You're right we should close it by now, doing it

@acezard acezard closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

@zatteo zatteo Awaiting requested review from zatteo zatteo will be requested when the pull request is marked ready for review zatteo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acezard @Ldoppea @Crash--