Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle hiding secure_background SplashScreen #894

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Aug 2, 2023

We want the app to correctly hide the new secure_background SplashScreen when the app goes active

The secure_background is a new SplashScreen that is displayed when the app is on OS background so the app's content is hiden when in this state

Note
All other showBackground and hideBackground don't take a name argument, so the default name is global (cf cozy/react-native-bootsplash#1 description)

Related PR: cozy/react-native-bootsplash#1


TODO:

This fork contains some Cozy specific code to ensure SplashScreen is
displayed when app is sent to background and to allow to show/hide
SplashScreens by names

Related PR: cozy/react-native-bootsplash#1
We want the app to correctly hide the new `secure_background`
SplashScreen when the app goes active

The `secure_background` is a new SplashScreen that is displayed when
the app is on OS background so the app's content is hiden when in this
state

Related PR: cozy/react-native-bootsplash#1
@Ldoppea Ldoppea force-pushed the fix/handle_splashscreen_background branch from 2a52c3e to 8fd69b7 Compare August 3, 2023 11:27
@Ldoppea Ldoppea merged commit 14ba0e2 into master Aug 3, 2023
1 check passed
@Ldoppea Ldoppea deleted the fix/handle_splashscreen_background branch August 3, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants