Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let cozy-clisk convert dataUri to arrayBuffer itself #895

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

doubleface
Copy link
Contributor

@doubleface doubleface commented Aug 4, 2023

See konnectors/libs#962

This fixes orange and sosh konnectors and will allow to deploy mgen konnector

Checklist

Before merging this PR, the following things must have been done:

  • Faithful integration of the mockups at all screen sizes
  • Tested on iOS
  • Tested on Android
  • Localized in English and French
  • All changes have test coverage
  • Updated README & CHANGELOG, if necessary

@doubleface doubleface force-pushed the fix/convertDataUriToFilestream branch 2 times, most recently from 858e289 to 44c1954 Compare August 4, 2023 13:19
@doubleface doubleface marked this pull request as ready for review August 4, 2023 13:28
@doubleface doubleface marked this pull request as draft August 4, 2023 13:28
@doubleface doubleface force-pushed the fix/convertDataUriToFilestream branch from 44c1954 to 588eb5c Compare August 4, 2023 14:32
@doubleface doubleface marked this pull request as ready for review August 4, 2023 14:33
@doubleface doubleface changed the title fix: Convert dataUri to filestream in saveFiles feat: Let cozy-clisk convert dataUri to arrayBuffer itself Aug 4, 2023
@doubleface doubleface merged commit 24269d2 into master Aug 4, 2023
1 check passed
@doubleface doubleface deleted the fix/convertDataUriToFilestream branch August 4, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants