[PRD-613] fix: Handle shared notes #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultranvan
requested review from
Ldoppea and
cballevre
and removed request for
acezard
paultranvan
changed the title
paultranvan
force-pushed
the
fix-sharing-link
branch
3 times, most recently
from
ccbbd62 to
b46bd48
Compare
When a note is coming from a Cozy sharing, a special URL must be built, including the sharing instance URL, a sharecode and a the note ID on this instance. The client does not have these information, so the stack is required to build the opening URL. This is directly handled by Drive, so when the user wants to open a shared note, we first need to redirect on Drive, that will redirect on Notes. See https://github.com/cozy/cozy-drive/pull/3244/files
paultranvan
force-pushed
the
fix-sharing-link
branch
from
b46bd48 to
6010fe2
Compare
cballevre
approved these changes
Nov 19, 2024
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Nov 20, 2024
paultranvan
added a commit
to cozy/cozy-web-data-proxy
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a note is coming from a Cozy sharing, a special URL must be built, including the sharing instance URL, a sharecode and a the note ID on this instance.
The client does not have these information, so the stack is required to build the opening URL. This is directly handled by Drive, so when the user wants to open a shared note, we first need to redirect on Drive, that will redirect on Notes.
See https://github.com/cozy/cozy-drive/pull/3244/files