[DAT-70] feat: Do not use flexsearch store #2623
Open
+135
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flexsearch has a built-in store capability, in order to store the full content of indexed documents. This is useful, however, this takes extra memory for nothing, as we already have the cozy-client store. All the indexed documents for the search are supposed to exist in cozy-client store, as we query them from Pouch at init, and retrieve updates from realtime, already plugged in cozy-client.
paultranvan
changed the title
Ldoppea
approved these changes
Nov 25, 2024
Comment on lines
+365
to
+381
| /* | ||
| Search result example: | ||
| [ | ||
| { | ||
| "field": "displayName", | ||
| "result": [ | ||
| "604627c6bafee013ec5f27f7f72029f6" | ||
| ] | ||
| }, | ||
| { | ||
| "field": "fullname", | ||
| "result": [ | ||
| "604627c6bafee013ec5f27f7f72029f6", "604627c6bafee013ec5f27f3f714568" | ||
| ] | ||
| } | ||
| ] | ||
| */ |
There was a problem hiding this comment.
Was that comment expected to be commited?
There was a problem hiding this comment.
Yes it was, it does not look like a good practice, but I honestly felt like it was helpful to better grasp the expected result quickly
| @@ -179,14 +180,13 @@ export class SearchEngine { | |||
| const fieldsToIndex = SEARCH_SCHEMA[doctype] | |||
|
|
|||
| const flexsearchIndex = new FlexSearch.Document<CozyDoc, true>({ | |||
| tokenize: 'forward', | |||
| tokenize: 'full', | |||
There was a problem hiding this comment.
nit: this change is not documented in the commit message and is not part of the "do not use flexsearch store" scope. Maybe you can add some precision in the commit message or extract it in another commit?
There was a problem hiding this comment.
Oh my, it's a mistake, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexsearch has a built-in store capability, in order to store the full content of indexed documents.
This is useful, however, this takes extra memory for nothing, as we already have the cozy-client store. All the indexed documents for the search are supposed to exist in cozy-client store, as we query them from Pouch at init, and retrieve updates from realtime, already plugged in cozy-client.