fix: SVG #917
Merged
fix: SVG #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It simplifies the diff between loaded with no sharings and not resolved yet when sharing.length=0
Since we can revoked and then apply again a sharing to the same user, we can have a conflict for the key
drazik
approved these changes
Jan 17, 2020
Crash--
force-pushed
the
feat/Sharing2
branch
from
15f3e51 to
26b16f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the SVG used are not displayed since we now use babel-react-svg-inline to load them instead of the Drive's loader :
Here is a screenshot of the issue:
As you can see all the "a" even if I have in my source :
<use xlink:href="#hourglass-path-1"></use>Also added a state to the provider to tell if we have done one request to sharing or not in order to give to the consumer a way to know if when sharings.length === 0 it's because there is no sharing or if the request is not done yet