[VO-1070 & VO-778 & VO-1036] feat(ApplicationPage): Add / remove additional apps from home page #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component is only responsible for applications and konnectors. It removes certain functionalities for additional apps, which will be added again in the next commit
cballevre
force-pushed
the
feat/add-remove-additional-apps
branch
from
e130fb4
to
13913a9
Compare
Ldoppea
approved these changes
Oct 8, 2024
Comment on lines
+40
to
+47
| } finally { | ||
| setBusy(false) | ||
| } |
There was a problem hiding this comment.
Is that expected that we don't catch anything? Don't we want to show an error message to the user?
There was a problem hiding this comment.
You're right, I added an alert to warn the user
This new component is responsible for the lifecycle of additional apps that shortcuts under the hood
Before this commit, we were limited to 100 shortcuts with this change we get every shortcuts inside specified folders in the config flag
cballevre
force-pushed
the
feat/add-remove-additional-apps
branch
from
13913a9
to
c016da9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs :