-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email notification of files that are about to expire #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merkur39
force-pushed
the
feat/notif-webpack
branch
2 times, most recently
from
December 5, 2022 11:31
ecae45a
to
f6dedd9
Compare
BundleMonFiles updated (1)
Unchanged files (24)
Total files change +433B +0.01% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
JF-Cozy
reviewed
Dec 5, 2022
JF-Cozy
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on semble assez aligné sur ce qu'il faut modifier, sous réserve de faire les modifs je valide pour te débloquer si besoin ;)
- Better date management. - The `getfilesNeedNotified` function now returns the normalized expiration and notification date, in addition to the file itself.
Added devDeps handlebars-layouts, mailhog & raw-loader. Added `uglify-js` resolution, the latter is a sub-dependency of `handlebars` and `html-minifier`, and it causes import problems. One approach is to use `Terser` (see https://www.npmjs.com/package/terser)
Using the `raw-loader` loader in the webpack config does not work, except when using the "inline" style, as here.
Updates all notified files so that they are no longer notified
Merkur39
force-pushed
the
feat/notif-webpack
branch
from
December 5, 2022 15:52
f6dedd9
to
e0e7575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR ajoute tout le code nécessaire pour l'envoi d'un email lorsque des fichiers arrivent bientôt à expiration (délai de prévenance).
Après merge de cozy/cozy-client#1274 et #330 nous pourrons mettre à jour le fichier le manifest pour activer le service en /dev