Teach should_run_leapp to check for the CLI option #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the check used by blockers to determine if the script will run leapp was incompatible with the check option as it only read a file that was written just prior to running stage 1. This updates the check to see if we should run leapp to also check to see if the --no-leapp option was passed via CLI in order to make the sub compatible with the check option. Fixes cpanel#332
toddr
reviewed
Jan 9, 2024
| my $no_leapp = read_stage_file( 'no_leapp', 0 ); | ||
| # we need to check to see if the no-leapp option is passed via CLI here too in order | ||
| # to allow users to run this script with the '--check --no-leapp' options | ||
| my $no_leapp = read_stage_file( 'no_leapp', 0 ) || $self->getopt('no-leapp'); |
There was a problem hiding this comment.
should we be checking the getopt first prior to going out to disk? I'm wondering if there are gotchas going in this order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check used by blockers to determine if the script will run leapp was incompatible with the check option as it only read a file that was written just prior to running stage 1. This updates the check to see if we should run leapp to also check to see if the --no-leapp option was passed via CLI in order to make the sub compatible with the check option.
Fixes #332
By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf