Add blocker if cPanel is not running version 110 #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog file with a line indicating what happened in this change. |
This is the last version to support c7, so we want to fix this script to only run on this version. This will minimize testing and risk moving forward. Fixes cpanel#337
|
This is currently blocked by the CI we have in place. The container that the CI uses is based on 102/Perl 5.32.0. We will need to update the CI to use a container based on 110/Perl 5.36.0. Unfortunately, that container does not yet exist so we will need to build it in the container project that we use: https://github.com/cpanel/docker-perl-compiler/tree/perl-v5.32.0 I am going to move on to 336 for now and revisit how to make the new container once 336 is fixed. |
|
I re-ran the job after updating the container for Perl v.5.36.0 and it passes :-) |
atoomic
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last version to support c7, so we want to fix this script to only run on this version. This will minimize testing and risk moving forward.
Fixes #337
By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf