-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wavelet Tree Module #4813
base: master
Are you sure you want to change the base?
Wavelet Tree Module #4813
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Changed time complexity Added braces
Changed the uniqueID
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think some of the content sections are a little confusing to read.
Could you:
- run it through a grammar checker (Grammarly?)
- make sure the user can follow the flow of logic (in the supporting updates section, you could create subheadings for updating indices & prefix arrays)
Thank you for your effort on this PR!
Co-authored-by: Ryan Chou <[email protected]>
Co-authored-by: Ryan Chou <[email protected]>
Co-authored-by: Ryan Chou <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution! |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution! |
Changes requested have not been made. Free free to create a new PR. |
Could you reopen this request I have addressed all the questions provided. |
BTW, have you addressed cryan's requested changes? (running the explanations through Grammarly & making sure the explanation has logical transitions, etc) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.