Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavelet Tree Module #4813

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Wavelet Tree Module #4813

wants to merge 63 commits into from

Conversation

crafticat
Copy link

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • [ x] I have tested my code.
  • [x ] I have added my solution according to the steps here.
  • [x ] I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • [ x] I have linked this PR to any issues that it closes.

crafticat and others added 30 commits May 15, 2024 21:07
Changed time complexity
Added braces
Changed the uniqueID
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think some of the content sections are a little confusing to read.

Could you:

  • run it through a grammar checker (Grammarly?)
  • make sure the user can follow the flow of logic (in the supporting updates section, you could create subheadings for updating indices & prefix arrays)

Thank you for your effort on this PR!

content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
Copy link

stale bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Nov 5, 2024
@stale stale bot removed the stale label Nov 5, 2024
Copy link

stale bot commented Nov 14, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Nov 14, 2024
Copy link

stale bot commented Nov 24, 2024

Changes requested have not been made. Free free to create a new PR.

@stale stale bot closed this Nov 24, 2024
@crafticat
Copy link
Author

Could you reopen this request I have addressed all the questions provided.

@TheGamingMousse
Copy link
Contributor

TheGamingMousse commented Nov 25, 2024

Could you reopen this request I have addressed all the questions provided.

  • If you have fixed an issue a comment pointed out, please resolve it
  • Make sure to request review next time

BTW, have you addressed cryan's requested changes? (running the explanations through Grammarly & making sure the explanation has logical transitions, etc)

@stale stale bot removed the stale label Nov 25, 2024
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
content/6_Advanced/Wavelet.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants