Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect find patch program under win32 #576

Closed
crackedmind opened this issue Jul 27, 2024 · 2 comments · Fixed by #581
Closed

Incorrect find patch program under win32 #576

crackedmind opened this issue Jul 27, 2024 · 2 comments · Fixed by #581

Comments

@crackedmind
Copy link

    if(GIT_EXECUTABLE) # C:/Program Files/Git/cmd/git.exe
      get_filename_component(extra_search_path ${GIT_EXECUTABLE} DIRECTORY)
      get_filename_component(extra_search_path ${extra_search_path} DIRECTORY)
      get_filename_component(extra_search_path ${extra_search_path} DIRECTORY)
      # and here we got C:/Program Files instead of C:/Program Files/Git
      find_program(PATCH_EXECUTABLE patch HINTS "${extra_search_path}/usr/bin")
    endif()
@ScottBailey
Copy link
Contributor

With a little more info, this can be an easy fix!

How did you install git? I mean from where?
And where is the patch command on your system?

Thanks!

@crackedmind
Copy link
Author

crackedmind commented Jul 31, 2024

git version 2.45.2.windows.1
installed from official installer to C:\Program Files\Git
patch.exe location of is C:\Program Files\Git\usr\bin\patch.exe
git.exe location is C:\Program Files\Git\cmd\git.exe

so. for my case second line get_filename_component(extra_search_path ${extra_search_path} DIRECTORY) is redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants