Additional search path for patch.exe #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crackedmind Please review and test this change on your system. I am unable to test it on mine. |
|
@ScottBailey it's working. |
|
@TheLartians It looks like finding I had considered using a recursive file glob, but this is a much simpler change that will succeed or fail much faster. If the directory structure continues to change, we can revisit file glob. Closes #576 Thank you for reporting @crackedmind |
TheLartians
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Thanks for the PR @ScottBailey, looks like a pragmatic fix!
Also thanks @crackedmind for reporting and testing this.
|
Fix is deployed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the windows installation locations of
patch.exeandgit.exehave either changed or are not fixed relative to one another (possibly based on install options?). Regardless, this change will search both the parent AND the parent-parent path forpatch.exe.Written to address #576.