Add restinio package #503
Add restinio package #503
Conversation
There was a problem hiding this comment.
Please follow the guide on cmake packages with dependencies and hunterize restinio
https://hunter.readthedocs.io/en/latest/creating-new/create/cmake-dependencies.html
| find_package(restinio CONFIG REQUIRED) | ||
| target_link_libraries(... restinio::restinio) | ||
|
|
||
| The reason you must manually bring in restinio's dependencies is because |
There was a problem hiding this comment.
dependencies are normally done by the hunterized package. The user of the package shouldn't need to specify dependencies by hand. Please hunterize restinio package instead following the documentation
https://hunter.readthedocs.io/en/latest/creating-new/create/cmake-dependencies.html
There was a problem hiding this comment.
As my comment in the docs notes, restinio is an INTERFACE library. Therefore, its cmake dependencies get exported with the target.
restinio is fully hunterised, see https://github.com/ned14/restinio/blob/master/CMakeLists.txt. This isn't the problem here.
There was a problem hiding this comment.
You can still add dependencies through the Config.cmake.in template methods that we generally use, no? https://github.com/cpp-pm/basis_universal/blob/hunter-1.15-c4c0db7/cmake/Config.cmake.in for example
| find_package(http-parser CONFIG REQUIRED) | ||
|
|
||
| hunter_add_package(fmt) | ||
| find_package(fmt CONFIG REQUIRED) |
There was a problem hiding this comment.
see remark above about hunter dependencies, please hnunterize the restinio package
| @@ -0,0 +1,21 @@ | |||
| [ | |||
There was a problem hiding this comment.
I don't know if this file is needed. I thought there is a default matrix.json and this override is only needed if you need to change toolchains
There was a problem hiding this comment.
restinio is not compatible with VS2015, hence me commenting it out. If there is a better way to do this, I'd be glad to hear.
|
What's weird here is that all the Windows CI targets work just fine, this issue only affects the POSIX CI targets. Weird. |
step by step carefully. Yes
Note that everything fails due to:
Yet I am setting
hunter_default_version, so I am officially stumped. Help would be appreciated.