Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

Buildsystem refactor and CMake support reimplementation #381

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Buildsystem refactor and CMake support reimplementation #381

wants to merge 13 commits into from

Conversation

DWVoid
Copy link

@DWVoid DWVoid commented May 26, 2018

No description provided.

DWVoid and others added 13 commits May 18, 2018 16:29
@DWVoid
Reformat
579f129
@DWVoid
Make Things Compile
0892e40
@DWVoid
refactor
d8ffec5
@DWVoid
Move Files
c09cf8b
@DWVoid
Reintendent
76319bb
@DWVoid
Idea
dcaf1c4
@DWVoid
Merge branch 'master' of https://github.com/cppit/jucipp
2bdb9f4 
# Conflicts:
#	src/cmake.cc
#	src/compile_commands.cc
#	src/ctags.cc
#	src/debug_lldb.cc
#	src/directories.cc
#	src/directories.h
#	src/documentation_cppreference.cc
#	src/entrybox.cc
#	src/entrybox.h
#	src/filesystem.cc
#	src/git.cc
#	src/git.h
#	src/menu.cc
#	src/menu.h
#	src/meson.cc
#	src/notebook.cc
#	src/notebook.h
#	src/project.cc
#	src/project.h
#	src/project_build.h
#	src/selection_dialog.cc
#	src/selection_dialog.h
#	src/source.cc
#	src/source.h
#	src/source_base.cc
#	src/source_base.h
#	src/source_clang.cc
#	src/source_clang.h
#	src/source_diff.cc
#	src/source_diff.h
#	src/source_language_protocol.cc
#	src/source_language_protocol.h
#	src/source_spellcheck.cc
#	src/source_spellcheck.h
#	src/terminal.cc
#	src/terminal.h
#	src/tooltips.cc
#	src/tooltips.h
#	src/usages_clang.cc
#	src/usages_clang.h
#	src/window.cc
@DWVoid
Simplfy Code
3c23846
@DWVoid
Reimplement CMake support with CBP
6df4473
@DWVoid
Add rapidxml
42c54fc
@DWVoid
Remove Trailing Whitespace
fb87b8e
@DWVoid
Refactoring
0cae947
@DWVoid
Minoring Code
5ad82df
@DWVoid
Copy link
Author

DWVoid commented May 26, 2018

@eidheim I have reimplemeted the cmake support with Codeblocks Project Generators to get more accurate project information. This PR also contains minor refactoring and reformating[I have no exact idea of the project coding style, this PR contains my best guess]
Tested with CMake 2.8.12, 3.7 and 3.10.

@eidheim
Copy link
Member

eidheim commented Jun 2, 2018

Thank you, but this PR has some issues:

  • Please do not style reformat the source files. I'd like to use clang-format at some point, but its support for lambda expressions is still poor. Also, when we will perform style format on the entire project, we will create and use a separate user account for this, so that no author gets credited for the changes done through style formatting.
  • The .idea directory should not be added in your commits
  • We use boost.property_tree for xml/json processing
  • No need to use polymorphism in the cmake/meson source files. These files are intended to be standalone so that they can be used by other projects. Polymorphish is however implemented in Project::Build instead.
  • We do not want to enforce use of a generator like the Codeblocks Project Generator. juCi++ should work on a preconfigured project that for instance have used a different generator.
  • There might be other issues as well, but I'm having a hard time reading the changes due to the number of line-changes in this PR.

@DWVoid
Copy link
Author

DWVoid commented Jun 8, 2018

I am sorry but where is the clang-format configuration file?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DWVoid @eidheim