Merge branch '__rultor'

pom.xml

@@ -234,6 +234,7 @@ SOFTWARE.
           <plugin>
             <groupId>com.qulice</groupId>
             <artifactId>qulice-maven-plugin</artifactId>
+            <version>0.18.17</version>
             <configuration>
               <excludes combine.children="append">
                 <exclude>checkstyle:/src/site/resources/.*</exclude>

src/main/java/org/jpeek/App.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -67,6 +67,7 @@
  * @checkstyle CyclomaticComplexityCheck (500 lines)
  * @checkstyle MethodLengthCheck (500 lines)
  * @checkstyle JavaNCSSCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  *
  * @todo #118:30min LCC metric has impediments (see puzzles in LCC.xml
  *  and in `MetricsTest`).
@@ -143,7 +144,10 @@ public App(final Path source, final Path target,
      * Analyze sources.
      * @throws IOException If fails
      */
-    @SuppressWarnings("PMD.ExcessiveMethodLength")
+    @SuppressWarnings({
+        "PMD.ExcessiveMethodLength",
+        "PMD.NcssCount"
+    })
     public void analyze() throws IOException {
         final Base base = new DefaultBase(this.input);
         final XML skeleton = new Skeleton(base).xml();

src/main/java/org/jpeek/Base.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -34,6 +34,7 @@
  * @author Yegor Bugayenko ([email protected])
  * @version $Id$
  * @since 0.1
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public interface Base {
 

src/main/java/org/jpeek/DefaultBase.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -37,6 +37,7 @@
  * @author Yegor Bugayenko ([email protected])
  * @version $Id$
  * @since 0.1
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class DefaultBase implements Base {
 

src/main/java/org/jpeek/FileTarget.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -36,6 +36,7 @@
  * @author Felipe Moreno ([email protected])
  * @version $Id$
  * @since 0.26.4
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class FileTarget implements Target {
 

src/main/java/org/jpeek/Header.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -39,6 +39,7 @@
  * @version $Id$
  * @since 0.8
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class Header implements Iterable<Directive> {
 

src/main/java/org/jpeek/Index.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -46,6 +46,7 @@
  * @version $Id$
  * @since 0.6
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class Index implements Iterable<Directive> {
 

src/main/java/org/jpeek/Main.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -42,7 +42,12 @@
  * @author Yegor Bugayenko ([email protected])
  * @version $Id$
  * @since 0.1
+ * @todo #308:30min Due to introduce new version of qulice 0.18.17 there were
+ *  many 'JavadocTagsCheck' suppression, so we need to fix that by remove
+ *  author, version and since tags in all javadoc. After that remove
+ *  'JavadocTagsCheck' suppression.
  * @checkstyle JavadocVariableCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class Main {
 

src/main/java/org/jpeek/Matrix.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -47,6 +47,7 @@
  * @version $Id$
  * @since 0.6
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class Matrix implements Iterable<Directive> {
 

src/main/java/org/jpeek/Report.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -56,12 +56,14 @@
  * @version $Id$
  * @since 0.1
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class Report {
     /**
      * Default mean.
      */
     private static final double DEFAULT_MEAN = 0.5d;
+
     /**
      * Default sigma.
      */
@@ -172,6 +174,7 @@ final class Report {
      * @param target Target dir
      * @throws IOException If fails
      */
+    @SuppressWarnings("PMD.GuardLogStatement")
     public void save(final Path target) throws IOException {
         final long start = System.currentTimeMillis();
         final XML xml = new StrictXML(

src/main/java/org/jpeek/ReportWithStatistics.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -44,6 +44,7 @@
  * @version $Id$
  * @since 0.16
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class ReportWithStatistics implements XML {
 

src/main/java/org/jpeek/Target.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -32,6 +32,7 @@
  * @author Felipe Moreno ([email protected])
  * @version $Id$
  * @since 0.26.4
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public interface Target {
 

src/main/java/org/jpeek/Version.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -37,6 +37,7 @@
  * @version $Id$
  * @since 0.11
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class Version implements Scalar<String> {
 

src/main/java/org/jpeek/package-info.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko

src/main/java/org/jpeek/skeleton/Classes.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -24,7 +24,6 @@
 package org.jpeek.skeleton;
 
 import com.jcabi.log.Logger;
-import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.nio.file.Files;
@@ -51,6 +50,7 @@
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class Classes implements Iterable<CtClass> {
 
@@ -74,7 +74,10 @@ final class Classes implements Iterable<CtClass> {
     }
 
     @Override
-    @SuppressWarnings("PMD.PrematureDeclaration")
+    @SuppressWarnings({
+        "PMD.PrematureDeclaration",
+        "PMD.GuardLogStatement"
+    })
     public Iterator<CtClass> iterator() {
         final Collection<CtClass> classes;
         final long start = System.currentTimeMillis();
@@ -88,8 +91,7 @@ public Iterator<CtClass> iterator() {
                     && !ctClass.getName().matches("^.+\\$AjcClosure[0-9]+$"),
                 new Mapped<>(
                     path -> {
-                        try (InputStream stream =
-                            new FileInputStream(path.toFile())) {
+                        try (InputStream stream = Files.newInputStream(path)) {
                             return this.pool.makeClassIfNew(stream);
                         }
                     },

src/main/java/org/jpeek/skeleton/OpsOf.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -41,6 +41,7 @@
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ParameterNumberCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class OpsOf extends MethodVisitor {

src/main/java/org/jpeek/skeleton/QualifiedName.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -34,6 +34,7 @@
  * @author Ilya Kharlamov ([email protected])
  * @version $Id$
  * @since 0.29
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class QualifiedName extends TextEnvelope {
     /**

src/main/java/org/jpeek/skeleton/Skeleton.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -59,6 +59,7 @@
  * @since 0.23
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 public final class Skeleton {
 
@@ -139,7 +140,10 @@ public XML xml() {
      * Calculate Xembly for all packages.
      * @return XML for all packages (one by one)
      */
-    @SuppressWarnings("PMD.AvoidInstantiatingObjectsInLoops")
+    @SuppressWarnings({
+        "PMD.AvoidInstantiatingObjectsInLoops",
+        "PMD.GuardLogStatement"
+    })
     private Iterable<Map.Entry<String, Directives>> packages() {
         final long start = System.currentTimeMillis();
         final Collection<Map.Entry<String, Directives>> all =

src/main/java/org/jpeek/skeleton/TypesOf.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -45,6 +45,7 @@
  * @since 0.27
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class TypesOf extends SignatureVisitor implements Iterable<Directive> {
 

src/main/java/org/jpeek/skeleton/XmlClass.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -51,6 +51,7 @@
  * @checkstyle AbbreviationAsWordInNameCheck (5 lines)
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @checkstyle ParameterNumberCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class XmlClass extends ClassVisitor implements Iterable<Directive> {

src/main/java/org/jpeek/skeleton/package-info.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko

src/main/java/org/jpeek/web/AsyncReports.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -46,6 +46,7 @@
  * @version $Id$
  * @since 0.8
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class AsyncReports implements
     BiFunc<String, String, Func<String, Response>> {

src/main/java/org/jpeek/web/DyNum.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -38,13 +38,14 @@
  * @version $Id$
  * @since 0.17
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 final class DyNum extends Number {
 
     /**
      * Score multiplier.
      */
-    private static final Double MULTIPLIER = 100000.0d;
+    private static final Double MULTIPLIER = 100_000.0d;
 
     /**
      * Serialization marker.

src/main/java/org/jpeek/web/Dynamo.java

@@ -1,4 +1,4 @@
-/**
+/*
  * The MIT License (MIT)
  *
  * Copyright (c) 2017-2019 Yegor Bugayenko
@@ -43,6 +43,7 @@
  * @version $Id$
  * @since 0.14
  * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
+ * @checkstyle JavadocTagsCheck (500 lines)
  */
 @SuppressWarnings("PMD.AvoidDuplicateLiterals")
 final class Dynamo implements Region {