Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#118 LCC metric has impediments #236

Closed
wants to merge 4 commits into from
Closed

#118 LCC metric has impediments #236

wants to merge 4 commits into from

Conversation

uurl
Copy link
Contributor

@uurl uurl commented May 19, 2018

For #118

Issue
LCC metric has impediments. Need to wait for resolving these impediments, add LCC to reports list and cover it by tests.

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

@yegor256/z please, pay attention to this pull request

@0crat 0crat added the scope label May 19, 2018
@0crat
Copy link
Collaborator

0crat commented May 19, 2018

Job #236 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 19, 2018

@yegor256/z everybody who has role REV are banned at #236; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Member

@uurl you duplicate your code in multiple PRs. Please, make sure each PR has only one piece of functionality.

@uurl
Copy link
Contributor Author

uurl commented May 19, 2018

@yegor256 this PR just solves the issue #118

@yegor256
Copy link
Member

@uurl I see here the changes already merged in https://github.com/yegor256/jpeek/pull/238/files

@uurl
Copy link
Contributor Author

uurl commented May 19, 2018

@yegor256 Yes, but I also need to fix the pull #238 for the MWE puzzle

@uurl uurl closed this May 19, 2018
@0crat 0crat removed the scope label May 19, 2018
@0crat
Copy link
Collaborator

0crat commented May 19, 2018

The job #236 is now out of scope

@uurl uurl deleted the issue118 branch May 19, 2018 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants