(#227) Refactor setting schema reference attribute #325
Conversation
|
Job #325 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
+ Coverage 75.58% 75.63% +0.04%
Complexity 184 184
============================================
Files 34 34
Lines 1102 1104 +2
Branches 88 88
============================================
+ Hits 833 835 +2
Misses 238 238
Partials 31 31
Continue to review full report at Codecov.
|
|
This pull request #325 is assigned to @ilyakharlamov/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
Also ensure in XPATH argument that metric is the root element.
|
@Protagores Are you sure you want to create a pull request from your master? That's usually a bad practice because you will not be able to change anything else, you will not be able to fix any other bug without affecting this issue. I recommend you to cancel this pull request, create a separate branch exclusively for this issue #227, make the fixes only in that branch and submit a new pull request. |
|
Job was finished in 2 hours, bonus for fast delivery is possible (see §36) |
|
@fabriciofx/z please review this job completed by @ilyakharlamov/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
Job #325 is not in the agenda of @ilyakharlamov/z, can't inspect |
|
The job #325 is now out of scope |
|
@0crat quality bad |
|
Quality is low, no payment, see §31 |
|
Quality review completed: +4 point(s) just awarded to @fabriciofx/z |
As per #227:
Refactored the addition of
xsi:noNamespaceSchemaLocationto generatedmetric.xmlinto applying a few Xembly instructions instead of an XSL transformation.Three instructions were eventually needed—one to point the cursor to the
metricelement (since it points above the root element by default), one to declare the XML namespace of the schema location attribute, and one to set the location itself.