Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

403: Skeleton should reflect the exact overloaded called method #432

Merged
merged 9 commits into from
Apr 1, 2020
Merged

403: Skeleton should reflect the exact overloaded called method #432

merged 9 commits into from
Apr 1, 2020

Conversation

dgarus
Copy link
Contributor

@dgarus dgarus commented Mar 25, 2020

@0crat
Copy link
Collaborator

0crat commented Mar 25, 2020

This pull request #432 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2020

@fanifieiev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

Copy link

@fanifieiev fanifieiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarus Please see my comments

src/main/resources/org/jpeek/xsd/skeleton.xsd Outdated Show resolved Hide resolved
src/test/java/org/jpeek/skeleton/SkeletonTest.java Outdated Show resolved Hide resolved
@dgarus
Copy link
Contributor Author

dgarus commented Mar 31, 2020

@fanifieiev Thank you for the review.
I've fixed your comments.

Copy link

@fanifieiev fanifieiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarus Thx
@paulodamaso Please merge

Copy link
Collaborator

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgarus Two comments, please take a look

src/main/resources/org/jpeek/xsd/skeleton.xsd Outdated Show resolved Hide resolved
src/test/java/org/jpeek/skeleton/SkeletonTest.java Outdated Show resolved Hide resolved
@dgarus
Copy link
Contributor Author

dgarus commented Apr 1, 2020

@dgarus Two comments, please take a look

@paulodamaso fixed.

@paulodamaso
Copy link
Collaborator

@dgarus Thanks!

@paulodamaso
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 1, 2020

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b62ae0f into cqfn:master Apr 1, 2020
@rultor
Copy link
Collaborator

rultor commented Apr 1, 2020

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 16min)

@0crat
Copy link
Collaborator

0crat commented Apr 1, 2020

@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 1, 2020
@sereshqua
Copy link

@fanifieiev please make sure you will at least 3 issues during next CR, thanks!

@dgarus please make sure you will start all your comments with the name of the user they are addressed to, see for instance

@fanifieiev
Copy link

@fanifieiev please make sure you will at least 3 issues during next CR, thanks!

@dgarus please make sure you will start all your comments with the name of the user they are addressed to, see for instance

@sereshqua Sure, thx

@dgarus
Copy link
Contributor Author

dgarus commented Apr 1, 2020

@fanifieiev please make sure you will at least 3 issues during next CR, thanks!

@dgarus please make sure you will start all your comments with the name of the user they are addressed to, see for instance

@sereshqua Ok

@dgarus dgarus deleted the 403_Skeleton_should_reflect_overloaded_method branch April 1, 2020 15:33
@sereshqua
Copy link

@0crat quality acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants