Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of the elm module to Kotin #1466

Merged
merged 38 commits into from
Dec 12, 2024
Merged

Conversation

JPercival
Copy link
Contributor

No description provided.

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 22.65774% with 809 lines in your changes missing coverage. Please review.

Project coverage is 65.76%. Comparing base (61ea9a5) to head (0227523).
Report is 13 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
.../cqframework/cql/elm/evaluating/SimpleElmEngine.kt 0.00% 690 Missing ⚠️
...amework/cql/elm/visiting/BaseElmClinicalVisitor.kt 83.24% 19 Missing and 13 partials ⚠️
...java/org/cqframework/cql/elm/tracking/TrackBack.kt 0.00% 15 Missing ⚠️
...ork/cql/elm/serializing/ElmLibraryReaderFactory.kt 0.00% 13 Missing ⚠️
...ork/cql/elm/serializing/ElmLibraryWriterFactory.kt 0.00% 13 Missing ⚠️
...framework/cql/elm/evaluating/SimpleElmEvaluator.kt 0.00% 12 Missing ⚠️
...java/org/cqframework/cql/cql2elm/LibraryBuilder.kt 77.41% 3 Missing and 4 partials ⚠️
...rg/cqframework/cql/cql2elm/SystemMethodResolver.kt 0.00% 5 Missing and 1 partial ⚠️
...java/org/cqframework/cql/cql2elm/Cql2ElmVisitor.kt 87.09% 1 Missing and 3 partials ⚠️
...cqframework/fhir/npm/NpmLibrarySourceProvider.java 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1466      +/-   ##
====================================================
- Coverage             66.02%   65.76%   -0.27%     
- Complexity             3001     4844    +1843     
====================================================
  Files                   486      487       +1     
  Lines                 28447    28824     +377     
  Branches               5463     5437      -26     
====================================================
+ Hits                  18782    18955     +173     
- Misses                 7467     7654     +187     
- Partials               2198     2215      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
69.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 89c4d17 into feature-kotlin Dec 12, 2024
6 of 7 checks passed
@JPercival JPercival deleted the feature-kotlin-elm branch December 12, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants