Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert elm, elm-xmlutil, model-xmlutil to Kotlin Multiplatform (Kotlin feature branch) #1494

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

antvaset
Copy link
Contributor

What's included:

  • The elm, elm-xmlutil, model-xmlutil modules are converted to Kotlin Multiplatform.
  • BigDecimal is polyfilled with kt-math-js in Kotlin/JS. Native java.math.BigDecimal is used on the JVM. WASM is not supported at the moment.
  • ElmLibraryReader and ElmLibraryWriter are simplified to use kotlinx.io.Source and kotlinx.io.Sink or simple strings.

…atform. Polyfill BigDecimal with kt-math-js in JS.
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.89%. Comparing base (dfa7f4a) to head (5260d84).
Report is 1 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...otlin/org/cqframework/cql/cql2elm/CqlTranslator.kt 50.00% 2 Missing ⚠️
...tlin/org/cqframework/cql/cql2elm/LibraryManager.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1494      +/-   ##
====================================================
+ Coverage             68.13%   68.89%   +0.75%     
+ Complexity             4783     3990     -793     
====================================================
  Files                   464      442      -22     
  Lines                 27536    25482    -2054     
  Branches               5266     4525     -741     
====================================================
- Hits                  18762    17556    -1206     
+ Misses                 6618     5862     -756     
+ Partials               2156     2064      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit afaefc2 into feature-kotlin Jan 31, 2025
6 of 7 checks passed
@JPercival JPercival deleted the feature-kotlin-multiplatform-modules branch January 31, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants