Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for 3.2.0 release #517

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Prep for 3.2.0 release #517

merged 8 commits into from
Mar 1, 2024

Conversation

JPercival
Copy link
Collaborator

@JPercival JPercival commented Feb 28, 2024

Description

  • Github Issue:
  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

@JPercival JPercival requested a review from ddieppois February 28, 2024 23:42
daviddieppois added 3 commits February 29, 2024 11:21
Fixed issue with Jetty version conflicts. Forced use of jetty 11.0.16 as per wiremock requirement
Using newer version of Wiremock and changed jetty version to 11.0.20 as per wiremock 3.4.2 requirement
@ddieppois
Copy link
Contributor

@JPercival I noticed that the build was failing due to a conflict with Wiremock dependency which contained multiple version of Jetty (11 and 12). I noticed that multiple new version of wiremock came out with less vulnerability so I decided to update to the latest version and force the use of jetty 11.0.20 (as per wiremock requirement) with a dependency management node.
This seems to have fixed the issue and the only test that was failing du to Wiremock is now working.

@JPercival JPercival marked this pull request as ready for review February 29, 2024 22:59
Copy link
Contributor

@ddieppois ddieppois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me ! I'll make sure to put the coming test results into target/test-output!

@JPercival
Copy link
Collaborator Author

looks good to me ! I'll make sure to put the coming test results into target/test-output!

When you run mvn clean, it automatically deletes the target folder. It's also ignored in git. This way no test output gets accidentally committed and it's self-cleaning.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 20.85%. Comparing base (241bd02) to head (e8a2b59).

Files Patch % Lines
...g/cql_generation/builder/VmrToModelElmBuilder.java 0.00% 2 Missing ⚠️
...opencds/cqf/tooling/processor/IGTestProcessor.java 0.00% 2 Missing ⚠️
...cds/cqf/tooling/terminology/SpreadsheetHelper.java 50.00% 2 Missing ⚠️
...org/opencds/cqf/tooling/utilities/R4FHIRUtils.java 0.00% 2 Missing ⚠️
...g/opencds/cqf/tooling/utilities/STU3FHIRUtils.java 0.00% 2 Missing ⚠️
...rkit/StructureDefinitionElementBindingVisitor.java 0.00% 1 Missing ⚠️
...eleratorkit/StructureDefinitionElementVisitor.java 0.00% 1 Missing ⚠️
.../opencds/cqf/tooling/quick/QuickPageGenerator.java 0.00% 1 Missing ⚠️
...cqf/tooling/terminology/VSACValueSetGenerator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #517       +/-   ##
=============================================
+ Coverage          0   20.85%   +20.85%     
- Complexity        0     1494     +1494     
=============================================
  Files             0      282      +282     
  Lines             0    24090    +24090     
  Branches          0     3832     +3832     
=============================================
+ Hits              0     5024     +5024     
- Misses            0    18221    +18221     
- Partials          0      845      +845     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryantaustin13 bryantaustin13 self-assigned this Mar 1, 2024
Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - builds locally as well.

@JPercival JPercival merged commit 8ed5d7f into master Mar 1, 2024
4 checks passed
@JPercival JPercival deleted the release-3.2.0 branch March 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants