-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for 3.2.0 release #517
Conversation
Fixed issue with Jetty version conflicts. Forced use of jetty 11.0.16 as per wiremock requirement
Using newer version of Wiremock and changed jetty version to 11.0.20 as per wiremock 3.4.2 requirement
@JPercival I noticed that the build was failing due to a conflict with Wiremock dependency which contained multiple version of Jetty (11 and 12). I noticed that multiple new version of wiremock came out with less vulnerability so I decided to update to the latest version and force the use of jetty 11.0.20 (as per wiremock requirement) with a dependency management node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me ! I'll make sure to put the coming test results into target/test-output!
When you run |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
=============================================
+ Coverage 0 20.85% +20.85%
- Complexity 0 1494 +1494
=============================================
Files 0 282 +282
Lines 0 24090 +24090
Branches 0 3832 +3832
=============================================
+ Hits 0 5024 +5024
- Misses 0 18221 +18221
- Partials 0 845 +845 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - builds locally as well.
Description
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0