Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Roller Test Fixes #520

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Date Roller Test Fixes #520

merged 1 commit into from
Mar 22, 2024

Conversation

c-schuler
Copy link
Contributor

Description

Migrating to LocalDate for parsing and date arithmetic to avoid Java Date DST quirks

  • I've read the contribution guidelines
  • Code compiles without errors
  • Tests are created / updated
  • Documentation is created / updated

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 20.99%. Comparing base (772d1ee) to head (57b7eca).

Files Patch % Lines
...f/tooling/operations/dateroller/RollTestDates.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #520      +/-   ##
============================================
+ Coverage     20.98%   20.99%   +0.01%     
- Complexity     1519     1520       +1     
============================================
  Files           283      283              
  Lines         24300    24296       -4     
  Branches       3867     3867              
============================================
+ Hits           5099     5101       +2     
+ Misses        18352    18347       -5     
+ Partials        849      848       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bryantaustin13 bryantaustin13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sliver007 sliver007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@JPercival JPercival merged commit 42871a7 into master Mar 22, 2024
4 checks passed
@JPercival JPercival deleted the date-roller-localdate branch March 22, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants