Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Notes column updated: SpreadsheetValidateVSandCS output adjusted; #538

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

bryantaustin13
Copy link
Contributor

Description
Updated the Review notes column in the spreadsheet produced to have more "needed" cells. The logic uses here was this:
if ((null != bo.getBindingStrength() && bo.getBindingStrength().equalsIgnoreCase("required")) ||
null != bo.getMustSupport() && bo.getMustSupport().equalsIgnoreCase("Y") ||
null != bo.getBindingObjectExtension() && bo.getBindingObjectExtension().equalsIgnoreCase("qicore-keyElement") ||
bo.getCardinalityMin() > 0
Then add the needed text

For SpreadsheetValidateVSandCS the output was adjusted to contain the full URL of the value sets and the code systems.

  • Github Issue:
  • [X ] I've read the contribution guidelines
  • [ X] Code compiles without errors
  • Tests are created / updated
    Tests were not created, because both of these operations require a path to the FHIR-Spec folder and that is 964 mb and too large to include here.
  • Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 573 lines in your changes missing coverage. Please review.

Project coverage is 21.39%. Comparing base (955f07e) to head (6056d6b).

Files with missing lines Patch % Lines
...ooling/terminology/SpreadsheetValidateVSandCS.java 0.00% 198 Missing ⚠️
.../terminology/compatators/CodeSystemComparator.java 0.00% 105 Missing ⚠️
...terminology/fhirservice/FhirTerminologyClient.java 0.00% 93 Missing ⚠️
...qf/tooling/terminology/compatators/Comparator.java 0.00% 92 Missing ⚠️
...ng/terminology/compatators/ValuesetComparator.java 0.00% 69 Missing ⚠️
...rkit/StructureDefinitionElementBindingVisitor.java 0.00% 9 Missing ⚠️
...celeratorkit/StructureDefinitionBindingObject.java 0.00% 4 Missing ⚠️
...s/cqf/tooling/operation/ProfilesToSpreadsheet.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #538      +/-   ##
============================================
- Coverage     21.87%   21.39%   -0.49%     
+ Complexity     1673     1672       -1     
============================================
  Files           297      302       +5     
  Lines         25412    25984     +572     
  Branches       4008     4127     +119     
============================================
- Hits           5560     5558       -2     
- Misses        18931    19504     +573     
- Partials        921      922       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bryantaustin13
Copy link
Contributor Author

This is from this Jira ticket: https://icf.atlassian.net/browse/CQF-1175. But covers more items that were added verbally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant