-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Notes column updated: SpreadsheetValidateVSandCS output adjusted; #538
Open
bryantaustin13
wants to merge
18
commits into
master
Choose a base branch
from
spreadsheetValidateVSandCS
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # tooling-cli/src/main/java/org/opencds/cqf/tooling/cli/OperationFactory.java # tooling/pom.xml
# Conflicts: # tooling/src/main/java/org/opencds/cqf/tooling/acceleratorkit/StructureDefinitionElementBindingVisitor.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #538 +/- ##
============================================
- Coverage 21.87% 21.39% -0.49%
+ Complexity 1673 1672 -1
============================================
Files 297 302 +5
Lines 25412 25984 +572
Branches 4008 4127 +119
============================================
- Hits 5560 5558 -2
- Misses 18931 19504 +573
- Partials 921 922 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This is from this Jira ticket: https://icf.atlassian.net/browse/CQF-1175. But covers more items that were added verbally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the Review notes column in the spreadsheet produced to have more "needed" cells. The logic uses here was this:
if ((null != bo.getBindingStrength() && bo.getBindingStrength().equalsIgnoreCase("required")) ||
null != bo.getMustSupport() && bo.getMustSupport().equalsIgnoreCase("Y") ||
null != bo.getBindingObjectExtension() && bo.getBindingObjectExtension().equalsIgnoreCase("qicore-keyElement") ||
bo.getCardinalityMin() > 0
Then add the needed text
For SpreadsheetValidateVSandCS the output was adjusted to contain the full URL of the value sets and the code systems.
Tests were not created, because both of these operations require a path to the FHIR-Spec folder and that is 964 mb and too large to include here.
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0