Resubmitting the PR #81
Conversation
There was a problem hiding this comment.
Still not sure why this is cleared out?
There was a problem hiding this comment.
@brynrhodes - I think we saw this with Sara's PR as well. Not sure if this is just a weird GitHub comparison artifact when PR-ing from a fork? When I click View File under the ellipsis, here's what I see as the file contents:
#!/bin/bash
./_genonce.sh -watch
| @@ -16,7 +16,7 @@ codesystem "ConditionVerificationStatusCodes": 'http://terminology.hl7.org/CodeS | |||
| codesystem "AllergyIntoleranceClinicalStatusCodes": 'http://terminology.hl7.org/CodeSystem/allergyintolerance-clinical' | |||
| codesystem "AllergyIntoleranceVerificationStatusCodes": 'http://terminology.hl7.org/CodeSystem/allergyintolerance-verification' | |||
| codesystem "ObservationCategoryCodes": 'http://terminology.hl7.org/CodeSystem/observation-category' | |||
| codesystem "USCoreObservationCategoryExtensionCodes": 'http://hl7.org/fhir/us/core/CodeSystem/us-core-observation-category' | |||
| codesystem "USCoreObservationCategoryExtensionCodes": 'http://terminology.hl7.org/CodeSystem/observation-category' | |||
There was a problem hiding this comment.
This isn't right, this is specifically pointing to the USCoreObservationCategoryCodes, needs to keep the fhir/us/core CodeSystem reference
| @@ -1,6 +1,10 @@ | |||
| == Suppressed Messages == | |||
|
|
|||
| # Add warning and/or information messages here after you've confirmed that they aren't really a problem | |||
| # instructions for ignoreWarnings.txt https://confluence.hl7.org/pages/viewpage.action?pageId=66938614#ImplementationGuideParameters-ManagingWarningsandHints | |||
| # (And include comments like this justifying why) | |||
There was a problem hiding this comment.
Need to keep these instructional messages, this is a template IG that is supposed to provide documentation on how to build a content IG, this is an important part of that
| <extension url="http://hl7.org/fhir/StructureDefinition/structuredefinition-wg"> | ||
| <valueCode value="cqi"/> | ||
| </extension> | ||
| <url value="http://hl7.org/fhir/uv/mycontentig/ImplementationGuide/example.fhir.uv.mycontentig"/> |
There was a problem hiding this comment.
Don't change the URL here, this isn't an HL7 IG, it's a sample content IG, the "somewhere.org" URL is important, it's providing an example for what people should do
| <url value="http://somewhere.org/fhir/uv/mycontentig/ImplementationGuide/example.fhir.uv.mycontentig"/> | ||
| <extension url="http://hl7.org/fhir/StructureDefinition/structuredefinition-wg"> | ||
| <valueCode value="cqi"/> | ||
| </extension> |
There was a problem hiding this comment.
Don't add this extension here, this isn't a CQI WG IG
| <!-- This version will propagate to all artifacts unless the "propagate-version" extension is overridden --> | ||
| <version value="0.4.1"/> | ||
| <name value="YourComputableMyContentIGNameHere"/> | ||
| <title value="Your User Friendly Name for MyContentIG Here"/> | ||
| <status value="draft"/> | ||
| <experimental value="false"/> | ||
| <publisher value="HL7 International - [Some] Work Group"/> | ||
| <publisher value="HL7 International / Clinical Quality Information"/> |
There was a problem hiding this comment.
Don't change this value, this is example content illustrating what people should do
| <contact> | ||
| <telecom> | ||
| <!-- Or whatever URL and/or email address(es) are appropriate --> | ||
| <system value="url"/> | ||
| <value value="http://hl7.org/Special/committees/[something]"/> | ||
| <value value="http://www.hl7.org/Special/committees/cqi"/> |
There was a problem hiding this comment.
Don't change this value, this is an example IG
| @@ -391,7 +391,7 @@ | |||
| "reference": "#effective-data-requirements" | |||
| } | |||
| } ], | |||
| "url": "http://somewhere.org/fhir/uv/mycontentig/Measure/HIVViralSuppressionFHIRExample", | |||
| "url": "http://hl7.org/fhir/uv/mycontentig/Measure/HIVViralSuppressionFHIR", | |||
| "title": "Questionnaire Measure Example", | ||
| "status": "draft", | ||
| "experimental": true, | ||
| "date": "2024-05-05T18:40:05-07:00", | ||
| "description": "Example measure illustrating a continuous variable measure calculating scores from multiple questionnaires", | ||
| "library": [ "http://somewhere.org/fhir/uv/mycontentig/Library/QuestionnaireMeasureExample" ], | ||
| "library": [ "http://hl7.org/fhir/uv/mycontentig/Library/QuestionnaireMeasure" ], |
| @@ -224,19 +224,19 @@ | |||
| "reference": "#effective-data-requirements" | |||
| } | |||
| } ], | |||
| "url": "http://somewhere.org/fhir/uv/mycontentig/Measure/QuestionnaireMeasureExample", | |||
| "name": "QuestionnaireMeasureExample", | |||
| "url": "http://hl7.org/fhir/uv/mycontentig/Measure/QuestionnaireMeasure", | |||
Reverts #80