Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rpds.py for PyO3 0.23 #100

Merged
merged 3 commits into from
Nov 16, 2024
Merged

update rpds.py for PyO3 0.23 #100

merged 3 commits into from
Nov 16, 2024

Conversation

ngoldbaum
Copy link
Contributor

@ngoldbaum ngoldbaum commented Nov 12, 2024

Opening as a draft because PyO3 0.23 isn't out yet.

Along with accompanying uncommitted Cargo.toml updates, this passes the test suite on the free-threaded Python build.

@Julian
Copy link
Member

Julian commented Nov 12, 2024

Thanks! Really appreciated. Adding a CI environment which runs on the free-threaded build would also be nice I think whenever we do merge.

@ngoldbaum
Copy link
Contributor Author

See Quansight-Labs/free-threaded-compatibility#98 and linked issues if you're curious why I'm using quansight-labs/setup-python instead of the normal Github-maintained one. Hopefully we can switch it back soon.

We probably need to open a followup issue about multithreaded testing, marking the extension module as thread-safe, and uploading free-threaded wheels, but I think this is ready now.

@ngoldbaum ngoldbaum marked this pull request as ready for review November 15, 2024 21:13
@Julian
Copy link
Member

Julian commented Nov 15, 2024

Fantastic thanks again! I'll have a look tomorrow here (and read that linked issue) but this looks great.

(The CI failure is unrelated obviously, I forgot to disable zizmor in pre-commit.ci as it doesn't run there yet, will do that.)

@Julian Julian merged commit 2d2de0b into crate-py:main Nov 16, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants