Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import globbing docs #48

Merged
merged 12 commits into from
Jan 8, 2024
Merged

Add import globbing docs #48

merged 12 commits into from
Jan 8, 2024

Conversation

matkuliak
Copy link
Contributor

@matkuliak matkuliak commented Dec 5, 2023

Summary of the changes / Why this is an improvement

Added brief globbing docs

Checklist

@matkuliak matkuliak added the documentation Improvements or additions to documentation label Dec 5, 2023
@matkuliak matkuliak requested review from SStorm and proddata December 5, 2023 00:12
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving that section. I've added a few suggestions, feel free to use them or not.

docs/reference/overview.rst Outdated Show resolved Hide resolved
docs/reference/overview.rst Outdated Show resolved Hide resolved
docs/reference/overview.rst Outdated Show resolved Hide resolved
docs/reference/overview.rst Outdated Show resolved Hide resolved
docs/reference/overview.rst Show resolved Hide resolved
@proddata
Copy link
Member

Can we adjust this PR to also reflect the changes of https://github.com/crate/cloud/issues/1505 (Azure Import).
This is similiar to S3 Imports and also supports multi file imports

@matkuliak
Copy link
Contributor Author

Added section on imports for Azure Container/Blob Storage and also mentioned it in multiple-files-import section.

@matkuliak matkuliak requested review from amotl and proddata December 27, 2023 11:08
@@ -325,7 +325,7 @@ the file. The S3 Access Key ID, and S3 Secret Access Key are also needed. You
can also specify the endpoint for non-AWS S3 buckets. Keep in mind that you may
be charged for egress traffic, depending on your provider. There is also a
volume limit of 10 GiB per file for S3 imports. The usual file formats are
supported.
supported - CSV, Json, and Parquet.
Copy link
Contributor

@SStorm SStorm Dec 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
supported - CSV, Json, and Parquet.
supported - CSV (all variants), JSON (JSON-Lines, JSON Arrays and JSON Documents), and Parquet.

@matkuliak matkuliak requested review from proddata and SStorm January 8, 2024 09:28
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍. Maybe squash the commits before merging?

@matkuliak matkuliak merged commit 2a6cf77 into main Jan 8, 2024
3 checks passed
@matkuliak matkuliak deleted the mm/import-globbing branch January 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants