-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import globbing docs #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving that section. I've added a few suggestions, feel free to use them or not.
Can we adjust this PR to also reflect the changes of https://github.com/crate/cloud/issues/1505 (Azure Import). |
Co-authored-by: Andreas Motl <[email protected]> Co-authored-by: Georg Traar <[email protected]>
Added section on imports for Azure Container/Blob Storage and also mentioned it in multiple-files-import section. |
Co-authored-by: Georg Traar <[email protected]>
docs/reference/overview.rst
Outdated
@@ -325,7 +325,7 @@ the file. The S3 Access Key ID, and S3 Secret Access Key are also needed. You | |||
can also specify the endpoint for non-AWS S3 buckets. Keep in mind that you may | |||
be charged for egress traffic, depending on your provider. There is also a | |||
volume limit of 10 GiB per file for S3 imports. The usual file formats are | |||
supported. | |||
supported - CSV, Json, and Parquet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supported - CSV, Json, and Parquet. | |
supported - CSV (all variants), JSON (JSON-Lines, JSON Arrays and JSON Documents), and Parquet. |
Co-authored-by: Georg Traar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍. Maybe squash the commits before merging?
Summary of the changes / Why this is an improvement
Added brief globbing docs
Checklist