Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use verlib2.Version instead of crate.client._pep440.Version #422

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 17, 2024

About

Instead of vendoring Version from packaging, pull it in via shared library verlib2.

Problem

crash broke after releasing crate==0.35.0, so I've yanked it again.

ModuleNotFoundError: No module named 'crate.client._pep440'

-- https://github.com/crate/crash/actions/runs/7562783871/job/20593938496?pr=421#step:5:29

Blocked By

@amotl
Copy link
Member Author

amotl commented Jan 18, 2024

crash broke after releasing crate==0.35.0, so I've yanked it again.

Just released 0.35.1, including a corresponding fix to make both artefacts forward- and backward-compatible. 1

Footnotes

  1. Currently, we do not employ corresponding version pinning to strictly tie crate and crash together, that's why it needs to be compatible into both directions. Let us know if you think this should be discussed.

@amotl
Copy link
Member Author

amotl commented Jan 18, 2024

The CI run is dead slow on Python 3.12, because it is building pandas 2.0.3? It became part of crate[test], but why is it selecting such an old version, for which are surely no binary builds (wheels) available on PyPI?

  Building wheel for pandas (pyproject.toml): still running...
  Building wheel for pandas (pyproject.toml): still running...
  Building wheel for pandas (pyproject.toml): finished with status 'done'
  Created wheel for pandas: filename=pandas-2.0.3-cp312-cp312-linux_x86_64.whl size=46018100 

Edit: crate/crate-python#606 / release 0.35.2 improves the situation, the run on Python 3.12 is much faster now.

Instead of vendoring `Version` from `packaging`, pull it in via shared
library `verlib2`.

-- https://github.com/pyveci/verlib2
@amotl amotl force-pushed the amo/fix-version-compares branch from 9274ca8 to a5b3335 Compare January 18, 2024 18:23
@amotl amotl marked this pull request as ready for review January 18, 2024 18:31
@amotl amotl merged commit f9827db into master Jan 19, 2024
21 checks passed
@amotl amotl deleted the amo/fix-version-compares branch January 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants