Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE: Add DataGrip #35

Merged
merged 3 commits into from
Mar 22, 2024
Merged

IDE: Add DataGrip #35

merged 3 commits into from
Mar 22, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 2, 2023

Base automatically changed from modernize to main August 3, 2023 00:17
@seut
Copy link
Member

seut commented Feb 13, 2024

Relates to crate/crate#13502

@ckurze
Copy link

ckurze commented Feb 13, 2024

DataGrip provides a summary which information is needed to come up with a dedicated connector: https://www.jetbrains.com/datagrip/new_dbms/

@amotl amotl changed the title IDE: Add DataGrip and pgAdmin IDE: Add DataGrip Feb 13, 2024
@amotl amotl requested review from seut and surister February 13, 2024 11:42
@amotl
Copy link
Member Author

amotl commented Feb 13, 2024

I've removed pgAdmin from this patch, and diverted it to GH-81.

@amotl amotl marked this pull request as ready for review February 13, 2024 11:43
@amotl
Copy link
Member Author

amotl commented Mar 15, 2024

Thanks for approving, @seut. Are we sure about it? I would also like to have a confirmation by @proddata or @ckurze about it, if it can go in as-is, or if the explainer text should provide any notices about potential caveats or other shortcomings.

@surister
Copy link

A potential caveat is that many UI actions do not work, but the most important piece, the console, does, so in the end you can do pretty much everything in it.

@amotl amotl self-assigned this Mar 18, 2024
@amotl
Copy link
Member Author

amotl commented Mar 21, 2024

A potential caveat is that many UI actions do not work, but the most important piece, the console, does, so in the end you can do pretty much everything in it.

Thanks. Do you think we should add this statement, or a variant thereof, to the documentation as a little and humble remark?

@surister
Copy link

A potential caveat is that many UI actions do not work, but the most important piece, the console, does, so in the end you can do pretty much everything in it.

Thanks. Do you think we should add this statement, or a variant thereof, to the documentation as a little and humble remark?

I'd say yes, it's extremely easy to get this errors while using any jetbrains IDE and CrateDB

Comment on lines +25 to +29
:::{caution}
Please note while the query console works well, you will notice that many UI
actions do not work yet. We are tracking corresponding gaps at [Tool: DataGrip],
and appreciate any contributions to improve the situation.
:::
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surister: I've just added a corresponding note, as you suggested. Thanks again!

@amotl amotl merged commit 48dc9de into main Mar 22, 2024
4 checks passed
@amotl amotl deleted the amo/ide-more branch March 22, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants