Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate: Split "Analyze" section into BI vs. ML #53

Merged
merged 3 commits into from
Dec 24, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 24, 2023

About

Just a little refactoring to set the stage for a few content additions. The content wasn't changed much, but merely moved around.

/cc @surister

@amotl amotl force-pushed the amo/integrate-refactor branch from 7ca5ea0 to 9c5b722 Compare December 24, 2023 02:08
@amotl amotl marked this pull request as ready for review December 24, 2023 02:19
[![](https://www.cluvio.com/images/logos/cluvio/cluvio-logo-full_color-on_dark.svg){w=180px}](https://www.cluvio.com/)
[![cluvio-logo-full_color-on_dark.svg](https://github.com/crate/crate-clients-tools/assets/453543/cac142ef-412a-4a67-a63f-bf9d1ce92c84){w=180px}](https://www.cluvio.com/)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am just using GitHub as image host here. It worked well for a while already, so I never looked back.

/cc @matkuliak

Comment on lines -81 to +82
![](https://www.cluvio.com/images/features/custom-filters.png){h=200px}
![](https://www.cluvio.com/images/features/report-creator.png){h=200px}
![custom-filters.png](https://github.com/crate/crate-clients-tools/assets/453543/49ca6a35-239e-4915-951c-db6649fd35a4){h=200px}
![report-creator.png](https://github.com/crate/crate-clients-tools/assets/453543/844a5ffd-0b92-4c77-8cdd-0b5cc5b392b1){h=200px}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito.

Copy link

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestions


This documentation section enumerates analytics applications and frameworks,
which can be used for analyzing data in CrateDB.
This documentation section enumerates business analytics applications
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This documentation section enumerates business analytics applications
This documentation section lists business analytics applications

or contains sounds better imho

Copy link
Member Author

@amotl amotl Dec 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Changed it.

(ml-tools)=
# Machine Learning with CrateDB

This documentation section enumerates machine learning applications and frameworks,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@amotl amotl force-pushed the amo/integrate-refactor branch from 1047b05 to e42e143 Compare December 24, 2023 11:26
@amotl amotl merged commit 3c32ed2 into main Dec 24, 2023
4 checks passed
@amotl amotl deleted the amo/integrate-refactor branch December 24, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants