SQLAlchemy: Improve DDL compiler to ignore unsupported UNIQUE and FOREIGN KEY constraints
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
requested review from
seut,
matriv and
hlcianfagna
and removed request for
hlcianfagna
amotl
force-pushed
the
amo/sqlalchemy-improve-ddl-compiler
branch
from
a72748b to
ba624b3
Compare
2 tasks
matriv
reviewed
Sep 28, 2023
|
Good idea. I added 154d77a, to emit corresponding warnings, as you suggested. |
matriv
approved these changes
Sep 28, 2023
amotl
changed the title
UNIQUE and FOREIGN KEY constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Adjust SQLAlchemy's DDL compiler to ignore foreign key and uniqueness constraints, because CrateDB doesn't support them.
Background
At recent work about unlocking MLflow and LangChain to work together with CrateDB 12, we needed to add some patches/workarounds.
Both of those to be integrated here are pretty straight-forward and non-invasive, and just mask corresponding SQL features not supported by CrateDB anyway, in order run applications with typical data schemas. Other dialects essentially to the same on their corresponding weak spots.
P.S.: I am intending to bring in this patch before running another release, where users are currently waiting for.
/cc @hlcianfagna, @hammerhead, @surister
Footnotes
https://github.com/crate-workbench/mlflow-cratedb ↩
https://github.com/crate-workbench/langchain ↩