Use verlib2.Version for comparing versions
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seut
reviewed
Oct 24, 2023
amotl
commented
Oct 24, 2023
Comment on lines
-398
to
-403
| @property | ||
| def version(self) -> tuple: | ||
| """ | ||
| PATCH: Return version tuple for backward-compatibility. | ||
| """ | ||
| return self._version.release |
There was a problem hiding this comment.
@seut: This little polyfill needs to be added to verlib2, to make it compatible with the previous LooseVersion/StrictVersion classes from distutils.
There was a problem hiding this comment.
The snippet to gain backwards-compatibility has been added with verlib2 0.2.0. It resolves the issue of failing test cases.
amotl
force-pushed
the
amo/use-verlib2
branch
from
5a97eb2 to
251543c
Compare
seut
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
For not duplicating corresponding code any longer, there is the verlib2 package now, which includes the same canonical code from
packaging.versionas before, see GH-513.