Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit urllib3.Timeout instances for defining timeout values #603

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Permit urllib3.Timeout instances for defining timeout values #603

merged 2 commits into from
Jan 16, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 12, 2024 •
edited
Loading

About

Permit urllib3.Timeout instances for defining timeout values. Using that, you can configure both the socket connect and read timeout settings, in seconds.

Problem

When defining the timeout value as urllib3.Timeout instance,

HttpClient(crate_host, timeout=urllib3.Timeout(connect=0.01, read=None))

this error is raised:

float() argument must be a string or a real number, not 'Timeout'

References

@amotl amotl mentioned this pull request Jan 12, 2024
Merged
@amotl amotl requested review from seut and matriv January 12, 2024 04:02
@amotl amotl requested a review from surister January 12, 2024 04:03
@amotl amotl marked this pull request as ready for review January 12, 2024 04:08
matriv
matriv reviewed Jan 12, 2024
View reviewed changes
docs/by-example/http.rst Outdated Show resolved Hide resolved
CHANGES.txt Outdated Show resolved Hide resolved
@amotl
Chore: Fix pandas testing dependency by downgrading to pandas 2.0
d1cd913 
ImportError: cannot import name 'makeTimeDataFrame' from 'pandas._testing'
@amotl amotl requested a review from matriv January 12, 2024 23:32
@amotl amotl changed the title Stop decoding the timeout parameter strictly as scalar Permit urllib3.Timeout instances for defining timeout values Jan 12, 2024
matriv
matriv approved these changes Jan 13, 2024
View reviewed changes
CHANGES.txt Outdated Show resolved Hide resolved
@amotl
Permit urllib3.Timeout instances for defining timeout values.
d1441fe 
Using that, you can configure both the socket `connect` and `read`
timeout settings, in seconds.
@amotl amotl requested a review from mfussenegger January 13, 2024 12:41
@amotl amotl merged commit af27cb1 into master Jan 16, 2024
35 checks passed
@amotl amotl deleted the amo/fix-timeout branch January 16, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surister surister surister approved these changes

@matriv matriv matriv approved these changes

@mfussenegger mfussenegger mfussenegger approved these changes

@seut seut Awaiting requested review from seut

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amotl @mfussenegger @matriv @surister