Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use CrateDB nightly also for regular testing #624

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 17, 2024

About

CrateDB version was fixed to 5.4.5. This patch intends to use latest nightly.

Thoughts

latest will probably not work, because the test layer used here only understands specific version numbers, and nightly?

@matriv
Copy link
Contributor

matriv commented Jun 17, 2024

Do you have any concern to test on CI with nightly? It could potentially help us catch issues of incompatibilities between CrateDB and python, before a release.

@amotl
Copy link
Member Author

amotl commented Jun 17, 2024

Thanks. Let's go for nightly right away, also for regular testing. CrateDB Nightly is used for crate-python nightly CI jobs anyway, so let's synchronize this.

@amotl amotl force-pushed the amo/cratedb-latest branch from 06a41a5 to 942647f Compare June 17, 2024 19:05
@amotl amotl changed the title CI: Use CrateDB latest for regular testing CI: Use CrateDB nightly also for regular testing Jun 17, 2024
@amotl amotl requested a review from matriv June 17, 2024 19:06
@amotl amotl marked this pull request as ready for review June 17, 2024 19:06
@amotl
Copy link
Member Author

amotl commented Jun 17, 2024

Dialogue with self

Q: 404 Not Found @ https://cdn.crate.io/downloads/releases/cratedb/x64_mac/crate-latest.tar.gz -- what's that?
A: Ah right, that's why we pinned specific versions. 💡

Explanation

There are no nightly builds for x64_mac.

Conclusion

Putting this back into draft mode for now, and updating manually instead.

@amotl amotl marked this pull request as draft June 17, 2024 19:12
@amotl amotl force-pushed the amo/cratedb-latest branch from 942647f to 5a29a5a Compare October 2, 2024 21:25
@cla-bot cla-bot bot added the cla-signed label Oct 2, 2024
@amotl amotl force-pushed the amo/cratedb-latest branch from 5a29a5a to 7c44a06 Compare October 2, 2024 21:29
@amotl amotl added the triage An issue that needs to be triaged by a maintainer label Oct 31, 2024
@amotl
Copy link
Member Author

amotl commented Oct 31, 2024

This is an alternative that works now, by working around the no nightly builds for x64_mac problem. In this way, we can at least use CrateDB nightly for the Linux-based test matrix slots, also on regular PR builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed triage An issue that needs to be triaged by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants