Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Improve guidance about migrating to sqlalchemy-cratedb #636

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 27, 2024

About

Mention the switchover to sqlalchemy-cratedb both on the project's README, and the index page of the documentation, in order to give users who might be running into relevant flaws a better chance to discover the solution.

Preview

References

/cc @seut, @matriv

@amotl amotl requested review from simonprickett, surister, seut, matriv, hammerhead and hlcianfagna and removed request for seut and matriv June 27, 2024 11:48
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, left a suggestion (in 2 places).
LGTM, please wait for a look from another reviewer though, thx!

README.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
amotl and others added 2 commits July 1, 2024 11:34
Mention the switchover both on the project's README, and the index page
of the documentation, in order to give users who might be running into
relevant flaws a better chance to discover the solution.

Co-authored-by: Marios Trivyzas <[email protected]>
@amotl amotl force-pushed the amo/improve-sa-migration-docs branch from 3381cb1 to 4d61a4c Compare July 1, 2024 09:34
@amotl amotl merged commit 1ec0f54 into master Jul 1, 2024
12 checks passed
@amotl amotl deleted the amo/improve-sa-migration-docs branch July 1, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants