Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Fix "implicit namespace packages" migration #327

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 13, 2024

... by omitting `__init__.py` from `crate` namespace package altogether,
see "PEP 420" [1] and "Package Discovery and Namespace Package » Finding
namespace packages" [2].

[1] https://peps.python.org/pep-0420/
[2] https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#namespace-packages
@amotl amotl force-pushed the pep420-remove-init branch from ddb4f55 to 1ccd51a Compare November 13, 2024 23:57
@amotl amotl marked this pull request as ready for review November 14, 2024 00:08
@amotl
Copy link
Member Author

amotl commented Nov 15, 2024

ok to test

Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can/should remove any __init__.py file, e.g. https://github.com/crate/crate-qa/blob/master/tests/bwc/__init__.py?

@amotl
Copy link
Member Author

amotl commented Nov 21, 2024

We probably can/should remove any init.py file?

I am not sure: The test directory is no package directory at all, at one hand. On the other, it is treated as such more often than not, in development. In this case, it is still not a namespace package.

@amotl amotl merged commit be4159f into master Nov 21, 2024
2 checks passed
@amotl amotl deleted the pep420-remove-init branch November 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants