Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cratedb_rag_customer_support_langchain.ipynb notebook #423

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

hammerhead
Copy link
Member

Summary of the changes / Why this is an improvement

  1. There was a closing double quote around the URL at pip install, but no opening one
  2. Colab was not able to resolve dependencies within 30 minutes. Removing optional, but unused, pueblo dependencies fixed it.

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing!

Comment on lines 88 to +89
"# Note: If you are running in an environment like Google Colab, please use the absolute path of the requirements:\n",
"#!pip install -r https://raw.githubusercontent.com/crate/cratedb-examples/main/topic/machine-learning/llm-langchain/requirements.txt\""
"#!pip install -r https://raw.githubusercontent.com/crate/cratedb-examples/main/topic/machine-learning/llm-langchain/requirements.txt"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only submit this improvement, and omit the others. Dependencies have been improved on behalf of those patches:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undid the dependency changes

@hammerhead hammerhead force-pushed the hammerhead/fix-rag-notebook branch from af0eafa to e947536 Compare April 19, 2024 06:25
@hammerhead hammerhead merged commit 74e0101 into main Apr 19, 2024
1 check passed
@hammerhead hammerhead deleted the hammerhead/fix-rag-notebook branch April 19, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants