Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npgsql: Adjust .NET support and version numbers on CI #695

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Npgsql: Adjust .NET support and version numbers on CI #695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a531ca5
Npgsql: Remove support for .NET 6 and Npgsql 6
amotl Oct 24, 2024
badfb08
Npgsql: Add support for .NET 9
amotl Oct 24, 2024
7814a2d
Npgsql: Update CI to use versions 7.0.8 and 8.0.5
amotl Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/lang-npgsql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ jobs:
fail-fast: false
matrix:
os: [ 'ubuntu-latest' ]
dotnet-version: [ '6.0.x', '7.0.x', '8.0.x' ]
npgsql-version: [ '6.0.11', '7.0.7', '8.0.3' ]
dotnet-version: [ '7.0.x', '8.0.x', '9.0.x' ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 7 is no longer maintained while .NET 6 is (until November 2024). Would it make sense to wait for .NET 9 to be released (currently only released as RC)?

Copy link
Member Author

@amotl amotl Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 6

.NET 6 is maintained until November 2024.

Interesting. I think the build started failing on .NET 6 the other day, that's why I removed that slot.

-- https://github.com/crate/cratedb-examples/actions/runs/11358160147/job/31592225551

If you can find a different solution, we can keep that version. Otherwise, we may be able to bring it back later, when applicable, and when a solution can be found?

I definitively don't want to terminate validation of .NET 6 too early, this is probably just a CI hiccup, hopefully. My main intention was to spend a little amount of time to make the build succeed again, in order to prepare the Build Status page for the weekend.

On the other hand, November 2024 will be just around the corner, so, should we bother and investigate at all?

Copy link
Member Author

@amotl amotl Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 7

.NET 7 is no longer maintained.

Oh. Thanks. Do you think we should remove it from the CI matrix?

Copy link
Member Author

@amotl amotl Oct 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET 9

Would it make sense to wait for .NET 9 to be released (currently only released as RC)?

We are not doing any super strong promises here. I am always happy to unlock CI slots as soon as artefacts of major releases become available, even as RC versions, so our assets can be tested on them from the very beginning.

If you don't have any objections against that philosophy, let's embrace it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should remove it from the CI matrix?

As long as it doesn't hurt us, we can keep it.

don't want to terminate validation of .NET 6 too early

.NET 6 is gone next month anyway, so let's remove it instead of spending time on figuring out why it failed. It is unlikely any user will complain.

npgsql-version: [ '7.0.8', '8.0.5' ]
cratedb-version: [ 'nightly' ]

# https://docs.github.com/en/free-pro-team@latest/actions/guides/about-service-containers
Expand Down
2 changes: 1 addition & 1 deletion by-language/csharp-npgsql/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ need for a plugin.
Please note that Npgsql 5 is not supported starting with CrateDB 4.8.4, you
will need Npgsql 6 or newer.

.NET 6, 7, and 8 are supported, .NET 3.1, 4.6, and 5.0 may still work.
.NET 7, 8, and 9 are supported, .NET 3.1, 4.6, 5.0, and 6.0 may still work.


*****
Expand Down
2 changes: 1 addition & 1 deletion by-language/csharp-npgsql/demo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Npgsql" Version="8.0.3" />
<PackageReference Include="Npgsql" Version="8.0.5" />
<PackageReference Include="CommandLineParser" Version="2.9.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
<PackageReference Include="xunit" Version="2.9.2" />
Expand Down
Loading